Remove call pattern #372
Open
Remove call pattern #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- MSFraggerModificationTranslation.__call__ → translate() - SageModificationTranslation.__call__ → translate() - Update all callers to use explicit translate() method 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
mschwoer
approved these changes
Dec 6, 2025
| def _load_modifications(self, origin_df: pd.DataFrame) -> None: # noqa: ARG002 | ||
| """Parse modifications from PsmDfCols.TMP_MODS column (mapped from 'Assigned Modifications').""" | ||
| translator = MSFraggerModificationTranslation( | ||
| modification_translation = MSFraggerModificationTranslation( |
Contributor
There was a problem hiding this comment.
MSFraggerModificationTranslator? (same for the other)
Restores callable interface for backward compatibility with notebook tests. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This reverts commit e290862.
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- MSFraggerModificationTranslation -> MSFraggerModificationTranslator - SageModificationTranslation -> SageModificationTranslator - Update all usages in readers, tests, and notebooks 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
mschwoer
approved these changes
Dec 8, 2025
| @@ -0,0 +1,37 @@ | |||
| # Refactor TODO | |||
Contributor
There was a problem hiding this comment.
I think this file can be removed
Contributor
|
"Who you're gonna call?" - " |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the infamous
__call__pattern from modification translation