Use alignment to store Gc's rooted flag
#40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // XXX We can probably take advantage of alignment to store this | ||
| root: Cell<bool>, | ||
| ptr: Shared<GcBox<T>>, | ||
| ptr_root: Cell<NonZero<*const GcBox<T>>>, |
There was a problem hiding this comment.
We should make sure to also have the PhantomData here that used to be in Shared
|
I left a few in line comments. I'm very happy that we can have the efficient flag storage and coerce unsized now at the same time! Thanks for the patch :) |
|
Updated. |
|
LGTM, Thanks for the patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supplants #17