update for new TestDesc::allow_fail field #68
Conversation
| name: make_test_name(config, testpaths), | ||
| ignore: early_props.ignore, | ||
| should_panic: should_panic, | ||
| allow_fail: false, |
There was a problem hiding this comment.
This should likely be a field of the Config structure so that it's configurable.
There was a problem hiding this comment.
This code is copied from the upstream make_test() function: https://github.com/rust-lang/rust/blob/919c4a6707da3aa2cc9ff63e33057e1e2a90720b/src/tools/compiletest/src/main.rs#L479.
I think what we really want to do is to parse the attributes of the test to determine the intended value of allow_fail, but that would be less trivial of a change. Right now I only care about getting compiletest to run again.
I don't see how it would make sense to use a field of Config, as that struct is shared among all tests.
There was a problem hiding this comment.
I tend to agree that fixing this should take priority over implementing new features, because without this fix this crate is not usable right now.
Maybe a separate ticket can be opened to make this configurable?
|
Hi guys, sorry for the delay - I'll merge it now |
|
@dwrensha @SergioBenitez @colin-kiegel Do any of you want to be added as maintainers on this repo, in case @Manishearth and I are not responding quick enough? |
4 participants
Fixes breakage introduced by rust-lang/rust#42219.