-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Configparser setup: figuring out config.py, constants.py, dirs.py, CLI arguments, and more [WIP] #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Configparser setup: figuring out config.py, constants.py, dirs.py, CLI arguments, and more [WIP] #98
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
9cba5f7
move a bunch of variables from constants.py into the config.cfg file,…
leotrs b22135f
Prefer the use of COLOR_MAP over PALETTE
leotrs 97431fc
add initial config.cfg file
leotrs 61ff836
Merge branch 'master' into configparser-setup
leotrs 6d0d7a3
WIP setup of configparser
leotrs d0a7598
resolve merge conflicts
leotrs b86f358
answers some of the requested changes
leotrs b162109
solve merge conflicts
leotrs 32f72a0
split config into two dicts
leotrs b1a7475
fix usage of CONFIG and file_writer_config
leotrs 985e5f8
fix: data_files seems to be deprecated; add the config files to packa…
leotrs b00a51f
clarify comment
leotrs fae6927
install ffmpeg on linux
leotrs dfccf0d
travis setup
leotrs e6691f2
fix dumb
leotrs 392e26a
fix arg parsing by not passing the first argv to the config parser
leotrs 07c6c29
now try without upgrading the whole system
leotrs 27c12ba
fix: now --dry_run correctly overrides -w, -a, -s, -g, and -ig
leotrs dd3b780
fix: now support -o flag
leotrs d5bf02c
fix: move config.file_writer_config["gif_file_extension"] to constant…
leotrs a6c3165
do not prompt the user
leotrs aeb20cc
update comment
leotrs 83f0b84
Merge branch 'master' of github.com:ManimCommunity/manim into configp…
leotrs 5c2e085
change loglevel to debug in order to see what is going on in Windows …
leotrs 834063a
Prettier if statement
leotrs 754e50b
More idiomatic for loop
leotrs 7b6b370
Readability
leotrs 7ad6aa9
fix typo
leotrs cc11fef
Merge branch 'configparser-setup' of github.com:ManimCommunity/manim …
leotrs 1fe4505
reverse debugging changes
leotrs 85e6b79
some fixes by PG
leotrs a8e2a4e
fix merge conflicts
leotrs 9e5ea50
check for None and for empty string
leotrs 3b962e4
handle more general cases of file names
leotrs b3ebc9e
make the -s flag invalidate -w
leotrs bfaffc7
fix: use correct re method
leotrs a67015f
delete unnecessary code
leotrs 2ef1070
more pythonic
leotrs f24d9ef
fix merge conflicts from tests (#133)
leotrs e4837b4
update tests wo new config system
leotrs b660303
update tests to config system
leotrs 9077542
Loose ends
eulertour f4c8431
fix deprecatet variables
leotrs 4dfff03
Merge branch 'configparser-setup' of github.com:ManimCommunity/manim …
leotrs 0229f78
Add information to test failures
eulertour b69f6e8
Update config variables and paths in tests
eulertour File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.