-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Allow for Developer Installations Without Poetry #754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This looks very redundant to me. If you want to install with |
You're right. In my case, I was able to build the package since I had poetry installed. With the changes I made in this P.R, the would-be developer won't need This is basically a way to do an editable install without |
|
It doesn't seem like being unable to install poetry is a common problem, but if you really wanted to avoid it you can ask @cobordism about his setup. This change feels a lot like overfitting manim to suit a specific computer in the same way that grant did in the old version. |
|
Alright, so after concluding NEGOTIATIONS with @eulertour on discord, I've made the changes that we agreed on by deleting both the The only change now made is the inclusion of |
List of Changes
setup.pyfile that was removed by Move to Poetry #165 in commit a281afdsetuptoolstobuild-systemrequirements inpyproject.tomlsetup.pyfile from thetar.gzfile generated bypoetry build.Motivation
Using
poetryin tandem withpython3.9and MacOS Big Sur is extremely inconvenient for the time being.This is due to the fact that, since Python3.9 is so new,
poetryattempts to install all (nearly all) the dependencies by building from source, which inevitably fail on MacOS Big Sur since it is also extremely new.An alternative, unobtrusive method would be much better, not just in this specific case, but for any other similar scenarios that may pop up in the future.
Explanation for Changes
Re-adding the
setup.pyfile and addingsetuptoolsto thebuild-systemrequirements allows the developer to do an editable install via pip, the "old fashioned" way (bypython3 -m pip install -e .).As such, one need not use
poetry, unless they are building the project at the very end, which works regardless of whetherpoetryis used to install the library in the first place.For the sake of convenience, the python script
./script/make_manim_setup.pyhas been added to easily extract thesetup.pyfile and place it in the appropriate location, as well as clean up after it.Testing Status
Tested several times on Python3.9 with MacOS Big Sur. Installs perfectly each time, provided you have the python package
wheelinstalled.Further Comments
I am unsure of whether this method needs to go into the documentation, since it just provides an alternate route to installation instead of
poetry.Acknowledgement