FIX : fixed tuples in hashing, by converting them to lists #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huguesdevimeux
added
the
pr:easy review
huguesdevimeux
changed the title
kilacoda-old
reviewed
Oct 1, 2020
Co-authored-by: kilacoda <65204531+kilacoda@users.noreply.github.com>
nilaybhatia
approved these changes
Oct 1, 2020
Windows tests are curently failing on the whole repo ;/ |
behackl
approved these changes
Oct 2, 2020
Co-authored-by: Benjamin Hackl <devel@benjamin-hackl.at>
leotrs
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Explanation for Changes
Generally, scene caching iteratively check in every iterables for circular references. If one is found, then the value in the iterable causing the circular reference is replaced. Same if an element has already been processed.
The issue is, if the iterable is a tuple, as tuples are immutable, it is impossible to modyuf it
Testing Status
Acknowledgement