Skip to content

fix(mobject): get_start/get_end fall back to submobject points #4852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chessing234 wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

fix(mobject): get_start/get_end fall back to submobject points #4852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions manim/mobject/mobject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2380,11 +2380,21 @@ def get_z(self, direction: Vector3DLike = ORIGIN) -> float:

def get_start(self) -> Point3D:
"""Returns the point, where the stroke that surrounds the :class:`~.Mobject` starts."""
# Points may live only on submobjects (e.g. a Text/Tex-shaped mobject, or
# the result of a Transform onto one), so fall back to the family (#4510).
if self.has_no_points():
members = self.family_members_with_points()
if members:
return members[0].get_start()
self.throw_error_if_no_points()
return np.array(self.points[0])

def get_end(self) -> Point3D:
"""Returns the point, where the stroke that surrounds the :class:`~.Mobject` ends."""
if self.has_no_points():
members = self.family_members_with_points()
if members:
return members[-1].get_end()
self.throw_error_if_no_points()
return np.array(self.points[-1])

Expand Down
Loading