-
Notifications
You must be signed in to change notification settings - Fork 2.5k
add manim_directive module to reference manual #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add manim_directive module to reference manual #463
Conversation
|
Another alternative is to not add the manim directive to the reference manual, and refer to it at some point in the contributing guidelines e.g. |
True. We could refer to it from https://manimce.readthedocs.io/en/latest/contributing.html -- but in order to get sphinx autodoc magic to work from the contributing page, we would need to convert |
|
I think I'd rather do that! |
This means that the normal auto summary from manim functions will be separated from the |
|
I'll convert the contribution manual and prepare a suggestion. Stay tuned. :-) |
|
While converting the contribution guide to restructuredText, I found (and remembered) that following a 14 + 7 step guide to start contributing actually was a bit intimidating. I've split the guide in some smaller sections and updated the parts describing what happens in our pipeline. Review at will, the page can be found at https://manimce--463.org.readthedocs.build/en/463/contributing.html |
|
When navigating over the website, I found it a bit strange that when being here: Further, it would be nice, to have an overview, of what kind of contribution guide can be found where, like a table of contents in the beginning of the document.
Great idea! Maybe we can bring even a bit more overview into this section, and probably also bring together the wiki pages:
into this contribution document. |
I am not sure how to resolve this. The document is rooted in the "Changing manim's source code" section, which is why this menu is active in the side bar in https://manimce--463.org.readthedocs.build/en/463/reference/manim_directive.html#module-manim_directive. This is analogous to how modules in the reference manual are rendered.
I am not sure I understand what you mean. Introducing a third level of submenus would be inconsistent compared to the rest of the documentation, though. (Besides, I did not manage to do that, even if I wanted to; maybe our theme does not support that.) I'm very open for suggestions.
I agree, but would like to keep this PR manageable and talk about further unification in a dedicated issue. |
That is what I meant. But you are right, this would be inconsistent, and it really does not bother a lot at the moment. |
|
There was an unformatted list, now fixed with the latest commit. |
|
This has two approvals - what are we waiting for? |
Nothing, as far as I can tell. :-) I don't seem to have write permissions for the repo; someone else has to merge it. |
|
You now have write permissions. Sorry about that. |
No worries. Thanks! |

The module located in
docs/source/manim_directive.pyfor the.. manim::stuff in the documentation was not included in the reference manual so far.This is changed here.
Explanation for Changes
This is one of two possible approaches. Unfortunately, there does not seem to be a way to "unset" the
.. currentmodule:: manimdirective inreference.rst, so the path to all other entries need to be rewritten here.The alternative would be to move
manim_directive.pyback into the manim module (which also seems to be a common approach, e.g., matplotlib does the same). Personally, I am fine with either solution.Acknowledgement