Skip to content

Conversation

@henrikmidtiby
Copy link
Contributor

Overview: What does this pull request change?

This PR adds type annotations to moving_camera.py.

The process of adding type annotations have led to the following changes in the code:

  • moved setters closer to the associated properties (for frame_height, frame_width and frame_center)
  • extracted the method _get_bounding_box

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@github-project-automation github-project-automation bot moved this to 🆕 New in Dev Board Aug 13, 2025
@henrikmidtiby henrikmidtiby marked this pull request as ready for review August 13, 2025 20:24
Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-project-automation github-project-automation bot moved this from 🆕 New to 👍 To be merged in Dev Board Aug 13, 2025
@chopan050 chopan050 merged commit 6b66878 into ManimCommunity:main Aug 13, 2025
21 checks passed
@github-project-automation github-project-automation bot moved this from 👍 To be merged to ✅ Done in Dev Board Aug 13, 2025
@henrikmidtiby henrikmidtiby deleted the TypingMovingCamera branch August 14, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants