Skip to content

Add type annotations to composition.py #4366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chopan050 merged 9 commits into from
Aug 6, 2025
Merged

Add type annotations to composition.py #4366

chopan050 merged 9 commits into from
Aug 6, 2025

Conversation

@henrikmidtiby
Copy link
Contributor

@henrikmidtiby henrikmidtiby commented Aug 2, 2025

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@github-project-automation github-project-automation bot moved this to 🆕 New in Dev Board Aug 2, 2025
@henrikmidtiby henrikmidtiby marked this pull request as ready for review August 2, 2025 20:24
chopan050
chopan050 requested changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left some suggestions:

@github-project-automation github-project-automation bot moved this from 🆕 New to 👀 In review in Dev Board Aug 6, 2025
henrikmidtiby and others added 4 commits August 6, 2025 22:11
@henrikmidtiby @chopan050
Update manim/animation/composition.py
a99f277 
Co-authored-by: Francisco Manríquez Novoa <49853152+chopan050@users.noreply.github.com>
@henrikmidtiby @chopan050
Update manim/animation/composition.py
716f018 
Co-authored-by: Francisco Manríquez Novoa <49853152+chopan050@users.noreply.github.com>
@henrikmidtiby
...
24646ef
@chopan050
Merge branch 'main' into TypingComposition
d575aac
@chopan050 chopan050 enabled auto-merge (squash) August 6, 2025 20:36
chopan050
chopan050 approved these changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-project-automation github-project-automation bot moved this from 👀 In review to 👍 To be merged in Dev Board Aug 6, 2025
@chopan050 chopan050 merged commit c887b51 into ManimCommunity:main Aug 6, 2025
21 checks passed
@github-project-automation github-project-automation bot moved this from 👍 To be merged to ✅ Done in Dev Board Aug 6, 2025
@henrikmidtiby henrikmidtiby deleted the TypingComposition branch August 7, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chopan050 chopan050 chopan050 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Dev Board
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@henrikmidtiby @chopan050