Add type annotations to three_d_camera.py
#4356
Conversation
| def z_key(mob: Mobject) -> float: | ||
| if not (hasattr(mob, "shade_in_3d") and mob.shade_in_3d): | ||
| return np.inf | ||
| return np.inf # type: ignore[no-any-return] |
There was a problem hiding this comment.
Apparently np.inf is not considered a float by mypy.
chopan050
left a comment
chopan050
left a comment
There was a problem hiding this comment.
Thanks for the changes! I left some few suggestions:
|
|
||
| def modified_rgbas(self, vmobject, rgbas): | ||
| # TODO: Find a better way | ||
| def modified_rgbas(self, vmobject: VMobject, rgbas: MatrixMN) -> MatrixMN: |
There was a problem hiding this comment.
A comment rather than a suggestion for this PR.
MatrixMN seems like the most fit alias for now, but we should actually make a new alias specifically for RGBA arrays, since MatrixMN is more fit for matrices representing linear maps which are applied on vectors. This was actually part of a larger proposal I wrote a long time ago in a #development post on Discord.
There was a problem hiding this comment.
Then I suggest to continue to use MatrixMN for now, and then when we also can type check on the dimensions of the matrices it would be a suitable time to change the typing.
|
Thanks for the input and comments. I have addressed all of them. |
github-project-automation
bot
moved this from 👀 In review
to 👍 To be merged
in Dev Board
chopan050
changed the title
three_d_camera.py
2 participants
Overview: What does this pull request change?
This PR adds type annotations to
three_d_camera.py.Reviewer Checklist