Skip to content

Conversation

@OliverStrait
Copy link
Contributor

Overview: What does this pull request change?

Fixes a little decoding error when handling tex-errors.

Motivation and Explanation: Why and how do your changes improve the library?

  • Python uses default encoding provided by OS.
  • In windows, system default text encoding is some reason a ancient Microsoft cp1252-encoding, a version of ANSI.
  • Tex will produce Utf-8 encoded files and current system will produce decoding error if tex file include any utf-8 characters.

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@github-project-automation github-project-automation bot moved this to 🆕 New in Dev Board Jul 16, 2025
@JasonGrace2282 JasonGrace2282 added the pr:bugfix Bug fix for use in PRs solving a specific issue:bug label Jul 16, 2025
Copy link
Member

@JasonGrace2282 JasonGrace2282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, if tests pass let's merge this. Thanks!

@github-project-automation github-project-automation bot moved this from 🆕 New to 👍 To be merged in Dev Board Jul 16, 2025
@behackl behackl merged commit 3721fb1 into ManimCommunity:main Jul 20, 2025
21 checks passed
@github-project-automation github-project-automation bot moved this from 👍 To be merged to ✅ Done in Dev Board Jul 20, 2025
@OliverStrait OliverStrait deleted the encoding branch July 21, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:bugfix Bug fix for use in PRs solving a specific issue:bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants