Handle opacity and transparent images #4313
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
This PR fixes #4256
The
set_opacitymethod now uses both the specified alpha value and the alpha channel in the original image to calculate the alpha channel of the image that is shown in the animation.Further Information and Comments
The solution is based on PR 2923 by NicoWeio.
This PR mentions that it awaited a solution to how ImageMObject's are hashed.
This does not seem to be needed anymore.
Test code
Output before change

Output after change

Reviewer Checklist