Skip to content

Conversation

@alterdim
Copy link
Contributor

Fixes #4294
This is a very small PR that fixes a typo in advanced_tex_fonts.py.
I could not find the encoding error mentioned in the issue, Półtawskiego is encoded correctly on every occurence on my end.

@github-project-automation github-project-automation bot moved this to 🆕 New in Dev Board Jun 23, 2025
@chopan050 chopan050 changed the title Fixed Microsoft Typo Fix Microsoft typo in TexFontTemplateLibrary scene in example_scenes/advanced_tex_fonts.py Jun 23, 2025
Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-project-automation github-project-automation bot moved this from 🆕 New to 👍 To be merged in Dev Board Jun 23, 2025
@chopan050
Copy link
Contributor

For some reason, the docs failed to build. Can you double check that you can build them by running make html inside manim/docs? If the docs build correctly, can you please make an empty commit with git commit --allow-empty and push it to trigger the pipelines again?

@chopan050 chopan050 closed this Jun 23, 2025
@github-project-automation github-project-automation bot moved this from 👍 To be merged to ❌ Rejected in Dev Board Jun 23, 2025
@chopan050
Copy link
Contributor

Sorry for that. I made a mistake when trying to push an empty commit and ended up force-pushing the main branch to a previous state with no new commits, causing this PR to be automatically closed. I no longer have permission to fix this myself.

Can you please run

git reset --hard cb51f03c
git push --force origin main

to fix this?

@alterdim
Copy link
Contributor Author

Running the first command you've sent me gives me the error
fatal: ambiguous argument 'cb51f03c': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git <command> [<revision>...] -- [<file>...]'
I'm afraid I'm not git-savy enough to fix that myself

@chopan050 chopan050 reopened this Jun 24, 2025
@github-project-automation github-project-automation bot moved this from ❌ Rejected to 📋 Backlog in Dev Board Jun 24, 2025
@chopan050
Copy link
Contributor

It's ok. The branch got fixed and your commit fixing the typo came back, so I was able to reopen the PR. Sorry for the inconveniences! This time, the docs should build succesfully (I built them locally with no errors) and the PR should be ready to be merged.

@chopan050
Copy link
Contributor

Everything has succeeded and this is ready to merge. Thanks for this contribution!

@chopan050 chopan050 merged commit a1bb049 into ManimCommunity:main Jun 24, 2025
21 checks passed
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Dev Board Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Typo in docstring of TexFontTemplateLibrary

2 participants