-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix: AnimationGroup with negative z_index #4277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Merzlikin-Matvey
wants to merge
6
commits into
ManimCommunity:main
Choose a base branch
from
Merzlikin-Matvey:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
09dc7e7
Fixed negative z_index in AnimationGroup issue
Merzlikin-Matvey 8712c17
Added tests for negative z_index in animations
Merzlikin-Matvey 26e0fc9
Fixed the test on Linux and MacOS
Merzlikin-Matvey c079386
Slightly modified the test
Merzlikin-Matvey 139c5c7
Merge branch 'main' into main
Merzlikin-Matvey ccefe48
Merge branch 'main' into main
Merzlikin-Matvey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+3.97 KB
tests/test_graphical_units/control_data/geometry/negative_z_index_AnimationGroup.npz
Binary file not shown.
Binary file added
BIN
+6.91 KB
tests/test_graphical_units/control_data/geometry/negative_z_index_LaggedStart.npz
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check notice
Code scanning / CodeQL
Cyclic import Note