Include Text.gradient in hash to properly regenerate Text when its gradient changes
#4099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behackl
previously requested changes
Jan 19, 2025
Member
behackl
left a comment
behackl
left a comment
There was a problem hiding this comment.
Left a minor suggestion, but looks good to me in general. This does seem like somwhat of a bandaid fix; perhaps we should think about a more general solution for generating these hashes so that we do not need to specify all the possible arguments separately.
Otherwise, thanks for your contribution and please take a look at my suggestion.
Co-authored-by: Benjamin Hackl <devel@benjamin-hackl.at>
chopan050
approved these changes
Jul 25, 2025
chopan050
dismissed
behackl’s stale review
I just talked with Ben on Discord about commiting the suggestion and merging this PR. Since he was not on his computer at the time, he asked me to do it instead.
chopan050
changed the title
Text.gradient in its hash to properly regenerate Text when its gradient changes
chopan050
changed the title
Text.gradient in its hash to properly regenerate Text when its gradient changesText.gradient in hash to properly regenerate Text when its gradient changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Fixes #4096
Added color gradient of text Mobjects to Pango file name hash, fixes gradient text coloration issue here: ManimCE Doesn't Recognize Text Object's changes When Rerunning The Scene Due to Old Cache #4096
Motivation and Explanation: Why and how do your changes improve the library?
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist