Fixing the get_nth_subpath function in "opengl_vectorized_mobject.py".
#3790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "insert_n_curves_to_point_list" function requires the "points" argument to be a numpy array, since it calls the "get_bezier_tuples_from_points" function, which requires "points" to be a numpy array because it has the "return points.reshape((-1, nppc, 3))" statement. Ordinary lists do not have a "reshape" method. So we need to convert "sp1" and "sp2" to numpy arrays before calling the "insert_n_curves_to_point_list" function.
Update opengl_vectorized_mobject.py
chopan050
approved these changes
Jun 10, 2024
3 tasks
|
Closes #3038 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
insert_n_curves_to_point_listfunction requires thepointsargument to be a numpy array, since it calls theget_bezier_tuples_from_pointsfunction, which requirespointsto be a numpy array because it has thereturn points.reshape((-1, nppc, 3))statement. Ordinary lists do not have areshapemethod.So we need to convert
sp1andsp2to numpy arrays before calling theinsert_n_curves_to_point_listfunction.Motivation and Explanation: Why and how do your changes improve the library?
I fixed the
get_nth_subpathfunction, so it will work with the opengl renderer.Reviewer Checklist