Skip to content

Optimized various point-related :class:.VMobject methods #3292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
8b7bd2c
Optimized VMobject.consider_points_equals by not using np.allclose
chopan050 Jul 8, 2023
bd43d04
Optimized VMobject.add_points_as_corners
chopan050 Jul 8, 2023
b46e11e
Optimized VMobject.append_points
chopan050 Jul 8, 2023
f29980e
Changed 3 to self.dim in new VMobject.append_points
chopan050 Jul 8, 2023
9a97e80
Optimized VMobject's start_new_path and add_line_to, and added n_poin…
chopan050 Jul 8, 2023
109e955
Optimized VMobject's change_anchor_mode
chopan050 Jul 8, 2023
d411a73
Optimized VMobject's point_from_proportion
chopan050 Jul 8, 2023
c544d34
Optimized VMobject's get_anchors and get_arc_length
chopan050 Jul 8, 2023
209bcb2
Removed NumPy from VMobject.set_points_as_corners
chopan050 Jul 8, 2023
cf719e9
Removed list() in VMobject.append_vectorized_mobject
chopan050 Jul 8, 2023
ce0bf2a
Optimized VMobject.gen_cubic_bezier_tuples_from_points
chopan050 Jul 8, 2023
0470ca2
Added Mobject.memory and optimized VMobject.point_from_proportion via…
chopan050 Jul 9, 2023
70cf3cc
Rolled back memo in VMobject.get_nth_curve_length
chopan050 Jul 9, 2023
d771938
Rewrote VMobject.get_points_defining_boundary
chopan050 Jul 9, 2023
cc027b6
VMobject: improved subpath methods and align_points
chopan050 Jul 9, 2023
5eb8c09
Solved TODO in VMobject.align_points
chopan050 Jul 9, 2023
d403d4b
Corrected comment in VMobject.align_points
chopan050 Jul 9, 2023
dfb4478
Minor optimization in VMobject.pointwise_become_partial
chopan050 Jul 9, 2023
927b359
Added commentaries to VMobject.pointwise_become_partial
chopan050 Jul 9, 2023
48dd7e0
Fixed VMobject.get_arc_length using undefined num_curves - whoops
chopan050 Jul 12, 2023
d607913
Rolled back minor details
chopan050 Jul 16, 2023
af351e9
Fixed small issue in VMobject.get_subpath_split_indices_from_points
chopan050 Jul 16, 2023
d737ada
Converted p0 and p1 to ndarrays in VMobject.consider_points_equals an…
chopan050 Jul 16, 2023
1f73421
Added border case in VMobject.get_subpath_split_indices_from_points w…
chopan050 Jul 16, 2023
8d7c17b
Added border case in VMobject.get_subpath_split_indices_from_points w…
chopan050 Jul 16, 2023
a90462f
Merge branch 'optimized_vmobject_points' of https://github.com/chopan…
chopan050 Jul 16, 2023
22c123f
Updated commentaries in VMobject.pointwise_become_partial
chopan050 Jul 16, 2023
5b9bae2
Merge branch 'ManimCommunity:main' into optimized_vmobject_points
chopan050 Jul 16, 2023
85418db
Fixed comment in VMobject.append_points
chopan050 Jul 16, 2023
99f5c71
Merge branch 'optimized_vmobject_points' of https://github.com/chopan…
chopan050 Jul 16, 2023
99ea085
Removed binary_search import
chopan050 Jul 16, 2023
c6ebc78
minor changes in formatting and language
behackl Jul 16, 2023
f64b874
Corrected use of self.bezier_alphas in VMobject.change_anchor_mode
chopan050 Jul 16, 2023
e1603a5
Merge branch 'main' into optimized_vmobject_points
chopan050 Jul 16, 2023
ef69e4f
Fixed bad slicing when assigning handles in jagged mode in VMobject.c…
chopan050 Jul 16, 2023
3fdb54a
Corrected semantics and commentaries in VMobject.get_subpath_split_in…
chopan050 Jul 16, 2023
e88cd64
Fixed _init_curve_memory and _update_curve_memory using references in…
chopan050 Jul 16, 2023
7d3d477
Added missing check to return earlier if points are exactly the same …
chopan050 Jul 16, 2023
2fdb879
Removed consider_points_different and added docstrings to VMobject.ge…
chopan050 Jul 16, 2023
276426d
Replaced manual binary search with bisect.bisect_left in VMobject.poi…
chopan050 Jul 17, 2023
b08c9bd
Merge branch 'main' into optimized_vmobject_points
chopan050 Jul 17, 2023
c50d97f
Added comments regarding np.all in VMobject.consider_points_equals(_2d)
chopan050 Jul 17, 2023
4e30041
Merge branch 'optimized_vmobject_points' of https://github.com/chopan…
chopan050 Jul 17, 2023
80b1b3d
Merge branch 'main' of https://github.com/ManimCommunity/manim into o…
chopan050 Aug 18, 2023
35d04d4
Added ManimColor to Mobject
chopan050 Aug 18, 2023
403c2bf
Merge branch 'main' of https://github.com/ManimCommunity/manim into o…
chopan050 Jan 1, 2024
d6e3aaf
Fix align_points() when end null curves are actually stripped
chopan050 Jan 1, 2024
55997a7
Delete unwanted try-except
chopan050 Jan 1, 2024
f06ad84
Fix align_points() for real
chopan050 Jan 2, 2024
f1ba587
Rename 'n_points_per_cubic_curve' to 'n_points_per_curve' and 'nppcc'…
chopan050 Jan 2, 2024
262999b
Merge branch 'main' into optimized_vmobject_points
chopan050 May 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions manim/animation/changing.py
Original file line number Diff line number Diff line change
Expand Up @@ -162,5 +162,5 @@ def update_path(self, mob, dt):
if self.dissipating_time:
self.time += dt
if self.time - 1 > self.dissipating_time:
nppcc = self.n_points_per_curve
self.set_points(self.points[nppcc:])
nppc = self.n_points_per_curve
self.set_points(self.points[nppc:])
1 change: 1 addition & 0 deletions manim/mobject/mobject.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ def __init__(
self.updaters: list[Updater] = []
self.updating_suspended = False
self.color = ManimColor.parse(color)
self.memory = {}

self.reset_points()
self.generate_points()
Expand Down
Loading
Loading