Skip to content

Conversation

naveen521kk
Copy link
Member

Using \ isn't supported by LaTeX and simply errors out
saying it can't find the file. In this commit, the path is
converted to POSIX like path (ie. use /) before calling
LaTeX.

Overview: What does this pull request change?

This fixes LaTeX erroring out on Windows.
Fixes #3060

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

Using `\` isn't supported by LaTeX and simply errors out
saying it can't find the file. In this commit, the path is
converted to POSIX like path (ie. use `/`) before calling
LaTeX.

Fixes ManimCommunity#3060
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there was an issue after all -- thanks for spotting this. I'll take a look at the other recently submitted PRs, perhaps there are some more bugfixes that should be included -- but otherwise yeah, it does call for 0.17.1.

@behackl behackl added the pr:bugfix Bug fix for use in PRs solving a specific issue:bug label Dec 6, 2022
@behackl behackl merged commit c4eeb2e into ManimCommunity:main Dec 6, 2022
@naveen521kk naveen521kk deleted the fix-3060 branch December 6, 2022 18:11
@behackl behackl changed the title Always use / when calling LaTeX Always expand file paths using / when calling LaTeX Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:bugfix Bug fix for use in PRs solving a specific issue:bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't compile LaTeX code on Windows

2 participants