Skip to content

Prepared new release: v0.17.0 #3023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 2, 2022
Merged

Prepared new release: v0.17.0 #3023

merged 10 commits into from
Dec 2, 2022

Conversation

behackl
Copy link
Member

@behackl behackl commented Nov 15, 2022

@behackl behackl added the release A tracking issue for changes expected for a release label Nov 15, 2022
@naveen521kk
Copy link
Member

I would like to add support for Python 3.11 (adding it to CI tests) before releasing a new version, will make a PR soon.

@naveen521kk
Copy link
Member

As well, we should drop support for Python 3.7, since poetry is complaining

PS C:\dev\manim> poetry lock     
Updating dependencies
Resolving dependencies...

The current project's Python requirement (>=3.7,<3.12) is not compatible with some of the required packages Python requirement:
  - scipy requires Python >=3.8, so it will not be satisfied for Python >=3.7,<3.8
  - scipy requires Python >=3.7,<3.11, so it will not be satisfied for Python >=3.11,<3.12
  - scipy requires Python >=3.8,<3.11, so it will not be satisfied for Python >=3.7,<3.8 || >=3.11,<3.12
  - scipy requires Python >=3.8,<3.11, so it will not be satisfied for Python >=3.7,<3.8 || >=3.11,<3.12
  - scipy requires Python >=3.8,<3.12, so it will not be satisfied for Python >=3.7,<3.8
  - scipy requires Python >=3.8,<3.12, so it will not be satisfied for Python >=3.7,<3.8
  - scipy requires Python >=3.8, so it will not be satisfied for Python >=3.7,<3.8

Because no versions of scipy match >1.7.3,<1.8.0 || >1.8.0,<1.8.1 || >1.8.1,<1.9.0 || >1.9.0,<1.9.1 || >1.9.1,<1.9.2 || >1.9.2,<1.9.3 || >1.9.3,<2.0.0
 and scipy (1.7.3) requires Python >=3.7,<3.11, scipy is forbidden.
And because scipy (1.8.0) requires Python >=3.8,<3.11, scipy is forbidden.
And because scipy (1.8.1) requires Python >=3.8,<3.11
 and scipy (1.9.0) requires Python >=3.8,<3.12, scipy is forbidden.
And because scipy (1.9.1) requires Python >=3.8,<3.12
 and scipy (1.9.2) requires Python >=3.8, scipy is forbidden.
So, because scipy (1.9.3) requires Python >=3.8
 and manim depends on scipy (^1.7.3), version solving failed.

  • Check your dependencies Python requirement: The Python requirement can be specified via the `python` or `markers` properties

    For scipy, a possible solution would be to set the `python` property to ">=3.8,<3.12"
    For scipy, a possible solution would be to set the `python` property to ">=3.7,<3.11"
    For scipy, a possible solution would be to set the `python` property to ">=3.8,<3.11"
    For scipy, a possible solution would be to set the `python` property to ">=3.8,<3.11"
    For scipy, a possible solution would be to set the `python` property to ">=3.8,<3.12"
    For scipy, a possible solution would be to set the `python` property to ">=3.8,<3.12"
    For scipy, a possible solution would be to set the `python` property to ">=3.8,<3.12"

    https://python-poetry.org/docs/dependency-specification/#python-restricted-dependencies,
    https://python-poetry.org/docs/dependency-specification/#using-environment-markers

@behackl
Copy link
Member Author

behackl commented Nov 29, 2022

As well, we should drop support for Python 3.7, since poetry is complaining

This is somewhat unfortunate given that Python 3.7 is still the default for Debian Buster (which is still LTS until 2024: https://wiki.debian.org/LTS), but I guess we don't really have a choice. Let's do that in #3030?

@naveen521kk
Copy link
Member

naveen521kk commented Nov 29, 2022

This is somewhat unfortunate given that Python 3.7 is still the default for Debian Buster (which is still LTS until 2024: https://wiki.debian.org/LTS)

Is that really an issue? One can always compile recent versions of Python from the source. Also, we technically have to drop it because there's no release of scipy which supports both 3.7 as well 3.11.

Let's do that in #3030?

I've already done it :)

@behackl
Copy link
Member Author

behackl commented Nov 29, 2022

Is that really an issue?

No, not really. The Debian thing is more of a personal thought; the actual pity is that Python 3.7 is also not EOL until next year (https://endoflife.date/python) -- but well. I suppose nothing stops people from just installing an older version of Manim in that case. I'm fine with dropping 3.7. 👍

@behackl behackl marked this pull request as ready for review December 2, 2022 12:13
@behackl
Copy link
Member Author

behackl commented Dec 2, 2022

I've added some descriptions to add some context to highlights and breaking changes.

Assuming the pipeline doesn't reveal any further major problems (and if there are no objections), we'll have a release later today. 🥳

Copy link
Member

@naveen521kk naveen521kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've slightly edited a few titles, like that of #2925 and #3044, please rerender. Thanks!

@behackl behackl merged commit f4943c0 into main Dec 2, 2022
@behackl behackl deleted the release-v0.17.0 branch December 2, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release A tracking issue for changes expected for a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants