Show read cfg files in DEBUG mode only; change default testing mode to DEBUG #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed default logging level for tests to "DEBUG" Edited expected.txt to account for verbosity change.
kilacoda-old
approved these changes
Aug 15, 2020
huguesdevimeux
approved these changes
Aug 15, 2020
Alright, that's been changed. I'll revert it if anyone has any objections. Mentioning @leotrs, since this PR fixes the issue he opened and @azarzadavila since they added the |
leotrs
approved these changes
Aug 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Read Configuration Filesmessage into a debug log rather than an info log.verbose = DEBUGin all tests related to cfg files.tests/test_logging/expected.txtto account for the fact that debug messages will also appear.Motivation
Fixes #287
Testing Status
Pytest exits with 0 errors.
Further Comments
Should we rename
verbosetoverbosity?verbosemakes it seem like it's a boolean value, rather than multiple levels.Acknowledgement