-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Added example for path_arc keyword argument of :class:.Transform
#2849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This was very handy for me when trying to swap two parts of an equation around without them getting muddled together first. Thus, I want it to be more clear how to use this feature.
|
This looks good. Thank you for your work! But i'm not sure if we can support more Animations in the Documentation right now. @behackl might take a look in a few days. Till then we will just keep this here till we know for sure. |
|
But you can add it as a template though! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very fine to me! The example adds ~1.4 sec build time to the documentation which is fine I guess (we can always ask for more build time allowance if we need it).
I've left a bunch of suggestions and comments, please take a look.
|
Thank you for the excellent suggestions. |
|
Anything else to address? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
path_arc keyword argument of :class:.Transform
Overview: What does this pull request change?
This was very handy for me when trying to swap two parts of an equation around without them getting muddled together first. Thus, I want it to be more clear how to use the
path_arcfeature of Transform, so I added an example showing how the different angles change the movement path.Links to added or changed documentation pages
Transform Page
TransformPathArc.mp4
Reviewer Checklist