Skip to content

Conversation

@kjlubick
Copy link
Contributor

@kjlubick kjlubick commented Jun 24, 2022

Overview: What does this pull request change?

This was very handy for me when trying to swap two parts of an equation around without them getting muddled together first. Thus, I want it to be more clear how to use the path_arc feature of Transform, so I added an example showing how the different angles change the movement path.

Links to added or changed documentation pages

Transform Page

TransformPathArc.mp4

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

kjlubick added 2 commits June 24, 2022 18:06
This was very handy for me when trying to swap two parts of an equation around without them getting muddled together first. Thus, I want it to be more clear how to use this feature.
@MrDiver
Copy link
Collaborator

MrDiver commented Jun 25, 2022

This looks good. Thank you for your work! But i'm not sure if we can support more Animations in the Documentation right now. @behackl might take a look in a few days. Till then we will just keep this here till we know for sure.

@ad-chaos
Copy link
Collaborator

But you can add it as a template though!
https://github.com/ManimCommunity/manim/tree/main/manim/templates

Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very fine to me! The example adds ~1.4 sec build time to the documentation which is fine I guess (we can always ask for more build time allowance if we need it).

I've left a bunch of suggestions and comments, please take a look.

@kjlubick
Copy link
Contributor Author

Thank you for the excellent suggestions.

@behackl behackl added the documentation Improvements or additions to documentation label Jul 7, 2022
@behackl behackl self-assigned this Jul 7, 2022
@kjlubick
Copy link
Contributor Author

kjlubick commented Jul 9, 2022

Anything else to address?

Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@behackl behackl enabled auto-merge (squash) July 10, 2022 07:09
@behackl behackl changed the title Add example for Transform's path_arc Added example for path_arc keyword argument of :class:.Transform Jul 10, 2022
@behackl behackl added this to the v0.16.0 milestone Jul 10, 2022
@behackl behackl merged commit 001dd3e into ManimCommunity:main Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants