Skip to content

Updated deprecated pillow constants #2715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2022
Merged

Updated deprecated pillow constants #2715

merged 1 commit into from
May 9, 2022

Conversation

MrDiver
Copy link
Collaborator

@MrDiver MrDiver commented May 7, 2022 •
edited by behackl
Loading

Update deprecated pillow constants

Overview: What does this pull request change?

Changed Image. to Resampling. as mentioned in the pillow deprecation message! (Introduces missing typehints from the pillow library 🤔)

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@MrDiver MrDiver added the pr:deprecation Deprecation, or removal of deprecated code label May 7, 2022
@MrDiver MrDiver marked this pull request as ready for review May 7, 2022 15:00
Darylgolden
Darylgolden approved these changes May 8, 2022
View reviewed changes
Copy link
Member

@Darylgolden Darylgolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!

naveen521kk
naveen521kk approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@naveen521kk naveen521kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@naveen521kk naveen521kk added enhancement Additions and improvements in general and removed pr:deprecation Deprecation, or removal of deprecated code labels May 9, 2022
@naveen521kk naveen521kk merged commit 8627f2a into ManimCommunity:main May 9, 2022
@MrDiver MrDiver deleted the update_deprecated_pillow_constants branch May 9, 2022 20:16
@behackl behackl added this to the v0.16.0 milestone Jul 10, 2022
@behackl behackl changed the title fix(constants.py,image_mobject.py,opengl_image_mobject.py): Update de… Updated deprecated pillow constants Jul 12, 2022
@behackl behackl added maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements and removed enhancement Additions and improvements in general labels Jul 12, 2022
@behackl behackl mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darylgolden Darylgolden Darylgolden approved these changes

@naveen521kk naveen521kk naveen521kk approved these changes

Assignees
No one assigned
Labels
maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MrDiver @Darylgolden @naveen521kk @behackl