Renamed get_graph and its variants to :meth:~.CoordinateSystem.plot

[icedcoffeeee]

Overview: What does this pull request change?

• Renamed:
  • get_graph to :meth:~.CoordinateSystem.plot
  • get_implicit_curve to :meth:~.CoordinateSystem.plot_implicit_curve
  • get_parametric_curve to :meth:~.CoordinateSystem.plot_parametric_curve
  • get_line_graph to :meth:~.CoordinateSystem.plot_line_graph
  • get_derivative_graph to :meth:~.CoordinateSystem.plot_derivative_graph
• Deprecated their previous names

Motivation and Explanation: Why and how do your changes improve the library?

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

• The PR title is descriptive enough for the changelog, and the PR is labeled correctly
• If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
• If applicable: newly added functions and classes are tested

[hydrobeam]

Suggested extending deprecation date to v0.13.0, + the renaming should be applied where get_x are used in the docs too. But I do support the name change! 👍

[kolibril13]

Looks good to me in general!
plot is more intuitive than get_graph
Just one thing to note:
In manim this wont show the graph directly

ax.plot(lambda x: x ** 2, color=PURPLE_B)

In matplotlib, this would show the graph directly:

ax.plot(x, y)

That is not a big issue, but might cause confusion.
Suggestion:
Should we, maybe in a future pr, directly add the plot as an submobject to the ax mobject?

[Darylgolden]

Looks good to me in general! plot is more intuitive than get_graph Just one thing to note: In manim this wont show the graph directly

ax.plot(lambda x: x ** 2, color=PURPLE_B)

In matplotlib, this would show the graph directly:

ax.plot(x, y)

That is not a big issue, but might cause confusion. Suggestion: Should we, maybe in a future pr, directly add the plot as an submobject to the ax mobject?

Not sure, but since this isn't directly related to this PR, maybe open a new discussion/issue?

[Darylgolden]

Still some remnants of the old syntax here and here (there may be more, I haven't checked exhaustively). Could you go over it again with Ctrl+F to make sure there isn't anything missed?

[icedcoffeeee]

Still some remnants of the old syntax

Ah my bad, I went only went through the 'manim' subfolder 😅. It should be clear now

[kolibril13]

Not sure, but since this isn't directly related to this PR, maybe open a new discussion/issue?

Yes, that can be discussed in the future, for now this looks good to me!

[hydrobeam]

Should get_vertical_lines_to_graph/ get_t_label and all related methods in coordinate_system.py etc... remove mentions to graph and instead use curve instead? Since we're renaming get_graph to plot, this feels appropriate to me. It'd make more sense to unify the usage of graph/curve since they're currently used interchangably throughout the file/docs.

[icedcoffeeee]

@hydrobeam

remove mentions to graph and instead use curve instead?

I disagree, the term 'curve' brings a very general sense as opposed to 'graph' which is closely related to function plotting. I think of .plot() as the act of plotting which in turn returns a graph. .get_implicit_curve() on the other hand, just so happens to have very different meanings between 'implicit graph' and 'implicit curve'.

That being said, IMO the current naming of curves and graphs are already pretty understandable.

[Darylgolden]

Can you resolve the merge conflicts?

[christopher-besch]

I just gave it a quick grep -R and found this and this.
Besides that this looks good.

[icedcoffeeee]

found this and this.

Thanks! They were probably added sometime after I left this PR and I didn't notice

Replacements have been made.

[behackl]

LGTM, I also (strongly) support renaming get_graph to plot.