Skip to content

Fixed whitespace in info message issued by :meth:.SceneFileWriter.clean_cache #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2021
Merged

Fixed whitespace in info message issued by :meth:.SceneFileWriter.clean_cache #2126

merged 2 commits into from
Oct 2, 2021

Conversation

NicoWeio
Copy link
Contributor

@NicoWeio NicoWeio commented Oct 1, 2021 •
edited by behackl
Loading

…without breaking Manim. This is my second try after #2027 got merged with an invalid logger command. #2066 fixed the invalid command, but the missing whitespace was still there. This time, I tested my modification.

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@NicoWeio
fix missing whitespace in info message
9ad2062 
…without breaking Manim
@behackl behackl changed the title Fix whitespace in info message issued by :meth:.SceneFileWriter.clean_cache Fix whitespace in info message issued by :meth:.SceneFileWriter.clean_cache Oct 2, 2021
behackl
behackl approved these changes Oct 2, 2021
View reviewed changes
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@behackl behackl added the documentation Improvements or additions to documentation label Oct 2, 2021
@behackl behackl enabled auto-merge (squash) October 2, 2021 06:59
@behackl behackl changed the title Fix whitespace in info message issued by :meth:.SceneFileWriter.clean_cache Fixed whitespace in info message issued by :meth:.SceneFileWriter.clean_cache Oct 2, 2021
@behackl behackl added maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements and removed documentation Improvements or additions to documentation labels Oct 2, 2021
@behackl behackl merged commit c7199fa into ManimCommunity:main Oct 2, 2021
@NicoWeio NicoWeio deleted the fix-whitespace branch October 2, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behackl behackl behackl approved these changes

Assignees
No one assigned
Labels
maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NicoWeio @behackl