Skip to content

Improved wording in info message issued by :meth:.SceneFileWriter.clean_cache #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2021
Merged

Improved wording in info message issued by :meth:.SceneFileWriter.clean_cache #2027

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c814a4f
fix missing whitespace in info message
NicoWeio Sep 7, 2021
7492c0e
possible rewording
NicoWeio Sep 8, 2021
1cb269d
another rewording (log + docstring)
NicoWeio Sep 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions manim/scene/scene_file_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,7 @@ def combine_movie_files(self, partial_movie_files=None):
modify_atime(file_path)

def clean_cache(self):
"""Will clean the cache by removing the partial_movie_files used by manim the longest ago."""
"""Will clean the cache by removing the oldest partial_movie_files."""
cached_partial_movies = [
os.path.join(self.partial_movie_directory, file_name)
for file_name in os.listdir(self.partial_movie_directory)
Expand All @@ -585,8 +585,8 @@ def clean_cache(self):
for file_to_delete in oldest_files_to_delete:
os.remove(file_to_delete)
logger.info(
f"The partial movie directory is full (> {config['max_files_cached']} files). Therefore, manim has removed {number_files_to_delete} file(s) used by it the longest ago."
+ "You can change this behaviour by changing max_files_cached in config.",
f"The partial movie directory is full (> {config['max_files_cached']} files). Therefore, manim has removed the {number_files_to_delete} oldest file(s).",
"You can change this behaviour by changing max_files_cached in config.",
)

def flush_cache_directory(self):
Expand Down