Added support for using OpenGL in subprocess in Windows pipeline #1987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an environment variable in glcontext which can be used for the locating the `opengl32.dll`. Use that instead of dynamically loading the DLL which is error prone.
naveen521kk
force-pushed
the
ci-opengl-subproc
branch
from
c0efc3c to
788a9f6
Compare
k4pran
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
There is an environment variable in glcontext which can be used for the
locating the
opengl32.dll. Use that instead of dynamically loading theDLL which is error prone.
I have made a PR in moderngl for changing this in their docs moderngl/moderngl#477
Motivation and Explanation: Why and how do your changes improve the library?
Could help #1982
Reviewer Checklist