-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix #101 #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #101 #164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the docs gang strikes again
We should also keep in mind that the x/y_min/max values are eventually to be replaced with xRange/yRange (or x_range, however the variable should be called), though I think we should first push this fix, I'll then make an issue for switching to ranges if nothing like that is around yet. |
Co-authored-by: Pg Biel <9021226+PgBiel@users.noreply.github.com>
This merge is necessary to add a new test
@PgBiel Thank you so much Captain Docs ! I did your suggestions. Don't hesitate to check it, if you don't mind. I also thought to add a doc for NumberPlane, but how to do so with all the @XorUnison Why not, but for me x_max is fine. Why do you think it would be better with a range thing? |
Update : I also fixed a minor bug, when passing a value for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very effective, this problem has troubled me for a long time :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
@safinsingh Fixed, thank you |
Fixes #101
The issue was that the lines of
NumberPlane
were automatically centred on the axis, which could cause problem whenx_max
was not equal tox_min
. (same for y).Example of the issue :
Render this :


As you can see, x-paralleles lines are shifted to the left.
Now, this is fixed :
I tested it with tests set up by #133 (not merged yet) and locally.
I also added a little bit of docstrings.