-fp does not work on Ubuntu

[huguesdevimeux]

On Ubuntu, when passing -f flag (open the file in file browser) and -p (preview) no preview is shown, only the file browser is open, instead of both.

IIRC it is working on windows, as I remember having worked on this flag to make it work on Windows.

Seems like an easy PR

[leotrs]

Thanks for reporting. I find it extremely weird that many flags seem to be failing lately. I was able to use -p only last week. There must be a PR that messed this up recently.

Another sign we need more tests. All the regressions are getting frustrating. We can't release v0.1 if -p can break at any point. I suggest we stop merging PRs without new tests added.

[huguesdevimeux]

Yes, but how do you want to test -p and -f ?

[leotrs]

They're two of the most used flags, no?

…

On Sun, Sep 27, 2020, 11:26 AM Hugues Devimeux ***@***.***> wrote: Yes, but how do you want to test -p and -f ? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#484 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAILYAH6AWH4IN5AVAAMXZDSH5KQ5ANCNFSM4R3TQB5A> .

[huguesdevimeux]

Yes, I think so.

[naveen521kk]

Works for me on Windows. So it is only for Linux. For contributors, the below code needs to be fixed.

manim/manim/utils/file_ops.py

Lines 56 to 72 in 9271ca8

	def open_file(file_path, in_browser=False):
	current_os = platform.system()
	if current_os == "Windows":
	os.startfile(file_path if not in_browser else os.path.dirname(file_path))
	else:
	if current_os == "Linux":
	commands = ["xdg-open"]
	file_path = file_path if not in_browser else os.path.dirname(file_path)
	elif current_os.startswith("CYGWIN"):
	commands = ["cygstart"]
	file_path = file_path if not in_browser else os.path.dirname(file_path)
	elif current_os == "Darwin":
	commands = ["open"] if not in_browser else ["open", "-R"]
	else:
	raise OSError("Unable to identify your operating system...")
	commands.append(file_path)
	sp.Popen(commands)

[musabkilic]

I couldn't make -fp work on Windows either. The problem is, open_media_file runs once regardless if -f or -p or both of them are given at that time. (ofc doesn't run if neither is given)

manim/manim/__main__.py

Lines 25 to 43 in 97de346

	open_file = any(
	[file_writer_config["preview"], file_writer_config["show_in_file_browser"]]
	)
	if open_file:
	current_os = platform.system()
	file_paths = []
	if file_writer_config["save_last_frame"]:
	file_paths.append(file_writer.get_image_file_path())
	if (
	file_writer_config["write_to_movie"]
	and not file_writer_config["save_as_gif"]
	):
	file_paths.append(file_writer.get_movie_file_path())
	if file_writer_config["save_as_gif"]:
	file_paths.append(file_writer.gif_file_path)
	for file_path in file_paths:
	open_media_file(file_path, file_writer_config["show_in_file_browser"])

If -f is set, open_media_file opens the folder.

manim/manim/utils/file_ops.py

Lines 56 to 72 in 9271ca8

	def open_file(file_path, in_browser=False):
	current_os = platform.system()
	if current_os == "Windows":
	os.startfile(file_path if not in_browser else os.path.dirname(file_path))
	else:
	if current_os == "Linux":
	commands = ["xdg-open"]
	file_path = file_path if not in_browser else os.path.dirname(file_path)
	elif current_os.startswith("CYGWIN"):
	commands = ["cygstart"]
	file_path = file_path if not in_browser else os.path.dirname(file_path)
	elif current_os == "Darwin":
	commands = ["open"] if not in_browser else ["open", "-R"]
	else:
	raise OSError("Unable to identify your operating system...")
	commands.append(file_path)
	sp.Popen(commands)