MultiJson::ParseError is thrown on HTTP error 5XX #226
Comments
|
Same issue |
iulian03
added a commit
that referenced
this issue
Apr 10, 2024
…rror-handling improved error handling and updated tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
In case of HTTP errors 5XX, HTML can be returned - for example
<head><title>api.mangopay.com | 520: Web server is returning an unknown error</title> ...or<head><title>502 Bad Gateway</title> ....Current behavior
In this case the SDK throws
MultiJson::ParseErrorbecause it tries to decode the response body before checking the status code. We could rescue the parse error and retry but it feels unsafe in case there are valid requests that return a non-JSON body.Expected behavior
Ideally we can rescue
MangoPay::ResponseErrorand depending on the status code we decide whether we retry the request or not.The text was updated successfully, but these errors were encountered: