Fix PHP 8.2 and Other Related Issues

.gitignore

@@ -11,6 +11,6 @@ composer.lock
 
 .*
 !.github
-!.php_cs
+!.php-cs-fixer.*
 !.gitignore
 !.gitattributes

.php-cs-fixer.php

@@ -0,0 +1,18 @@
+<?php
+
+$finder = (new PhpCsFixer\Finder())
+	->in(__DIR__.'/MangoPay')
+	->in(__DIR__.'/tests')
+;
+
+return (new PhpCsFixer\Config())
+	->setRules([
+		'@PSR12' => true,
+		'fully_qualified_strict_types' => true,
+		'array_syntax' => ['syntax' => 'short'],
+		'visibility_required' => [
+			'elements' => ['property', 'method'], // 'const' is removed for old PHP compat
+		],
+	])
+	->setFinder($finder)
+	;

MangoPay/ApiBankAccounts.php

@@ -10,10 +10,10 @@ class ApiBankAccounts extends Libraries\ApiBase
     /**
      * Retrieves a list of Transactions pertaining to a certain Bank Account
      * @param string $bankAccountId Bank Account identifier
-     * @param \MangoPay\Pagination $pagination Pagination object
-     * @param \MangoPay\FilterTransactions $filter Filtering object
-     * @param \MangoPay\Sorting $sorting Sorting object
-     * @throws \MangoPay\Libraries\Exception
+     * @param Pagination $pagination Pagination object
+     * @param FilterTransactions $filter Filtering object
+     * @param Sorting $sorting Sorting object
+     * @throws Libraries\Exception
      */
     public function GetTransactions($bankAccountId, & $pagination = null, $filter = null, $sorting = null)
     {

MangoPay/ApiBankingAliases.php

@@ -10,7 +10,7 @@ class ApiBankingAliases extends Libraries\ApiBase
     /**
      * Get a banking alias
      * @param string $bankingAliasId Banking alias identifier
-     * @return \MangoPay\BankingAlias returned from API
+     * @return BankingAlias returned from API
      */
     public function Get($bankingAliasId)
     {
@@ -20,8 +20,8 @@ public function Get($bankingAliasId)
 
     /**
      * Create a banking alias
-     * @param \MangoPay\BankingAlias $bankingAlias Banking alias
-     * @return \MangoPay\BankingAlias returned from API
+     * @param BankingAlias $bankingAlias Banking alias
+     * @return BankingAlias returned from API
      * @throws Libraries\Exception
      */
     public function Create($bankingAlias)
@@ -39,8 +39,8 @@ public function Create($bankingAlias)
 
     /**
      * Update banking alias
-     * @param \MangoPay\BankingAlias $bankingAlias Card object to save
-     * @return \MangoPay\BankingAlias Card object returned from API
+     * @param BankingAlias $bankingAlias Card object to save
+     * @return BankingAlias Card object returned from API
      */
     public function Update($bankingAlias)
     {
@@ -50,8 +50,8 @@ public function Update($bankingAlias)
 
     /**
      * Get all banking aliases
-     * @param \MangoPay\Pagination $pagination Pagination object
-     * @param \MangoPay\Sorting $sorting Object to sorting data
+     * @param Pagination $pagination Pagination object
+     * @param Sorting $sorting Object to sorting data
      * @param string $walletId Wallet identifier
      * @return \MangoPay\BankingAlias[] List of banking aliases
      */
@@ -64,8 +64,8 @@ public function GetAll($walletId, & $pagination = null, $sorting = null)
     /**
      * Get correct banking alias object
      * @param object $response Response from API
-     * @return \MangoPay\BankingAlias BankingAlias object returned from API
-     * @throws \MangoPay\Libraries\Exception If occur unexpected response from API
+     * @return BankingAlias BankingAlias object returned from API
+     * @throws Libraries\Exception If occur unexpected response from API
      */
     private function GetBankingAliasResponse($response)
     {

MangoPay/ApiCardPreAuthorizations.php

@@ -9,8 +9,8 @@ class ApiCardPreAuthorizations extends Libraries\ApiBase
 {
     /**
      * Create new pre-authorization object
-     * @param \MangoPay\CardPreAuthorization $cardPreAuthorization PreAuthorization object to create
-     * @return \MangoPay\CardPreAuthorization PreAuthorization object returned from API
+     * @param CardPreAuthorization $cardPreAuthorization PreAuthorization object to create
+     * @return CardPreAuthorization PreAuthorization object returned from API
      */
     public function Create($cardPreAuthorization, $idempotencyKey = null)
     {
@@ -20,7 +20,7 @@ public function Create($cardPreAuthorization, $idempotencyKey = null)
     /**
      * Get pre-authorization object
      * @param string $cardPreAuthorizationId PreAuthorization identifier
-     * @return \MangoPay\CardPreAuthorization Card registration  object returned from API
+     * @return CardPreAuthorization Card registration  object returned from API
      */
     public function Get($cardPreAuthorizationId)
     {
@@ -29,8 +29,8 @@ public function Get($cardPreAuthorizationId)
 
     /**
      * Update pre-authorization object
-     * @param \MangoPay\CardPreAuthorization $cardPreAuthorization PreAuthorization object to save
-     * @return \MangoPay\CardPreAuthorization PreAuthorization object returned from API
+     * @param CardPreAuthorization $cardPreAuthorization PreAuthorization object to save
+     * @return CardPreAuthorization PreAuthorization object returned from API
      */
     public function Update($cardPreAuthorization)
     {

MangoPay/ApiCardRegistrations.php

@@ -9,8 +9,8 @@ class ApiCardRegistrations extends Libraries\ApiBase
 {
     /**
      * Create new card registration
-     * @param \MangoPay\CardRegistration $cardRegistration Card registration object to create
-     * @return \MangoPay\CardRegistration Card registration object returned from API
+     * @param CardRegistration $cardRegistration Card registration object to create
+     * @return CardRegistration Card registration object returned from API
      */
     public function Create($cardRegistration, $idempotencyKey = null)
     {
@@ -20,7 +20,7 @@ public function Create($cardRegistration, $idempotencyKey = null)
     /**
      * Get card registration
      * @param string $cardRegistrationId Card Registration identifier
-     * @return \MangoPay\CardRegistration Card registration  object returned from API
+     * @return CardRegistration Card registration  object returned from API
      */
     public function Get($cardRegistrationId)
     {
@@ -29,8 +29,8 @@ public function Get($cardRegistrationId)
 
     /**
      * Update card registration
-     * @param \MangoPay\CardRegistration $cardRegistration Card registration object to save
-     * @return \MangoPay\CardRegistration Card registration object returned from API
+     * @param CardRegistration $cardRegistration Card registration object to save
+     * @return CardRegistration Card registration object returned from API
      */
     public function Update($cardRegistration)
     {

MangoPay/ApiCards.php

@@ -10,7 +10,7 @@ class ApiCards extends Libraries\ApiBase
     /**
      * Get card
      * @param string $cardId Card identifier
-     * @return \MangoPay\Card object returned from API
+     * @return Card object returned from API
      */
     public function Get($cardId)
     {
@@ -22,8 +22,8 @@ public function Get($cardId)
      * The fingerprint is a hash uniquely generated per 16-digit card number.
      *
      * @param string $fingerprint The fingerprint hash
-     * @param \MangoPay\Pagination $pagination Pagination object
-     * @param \MangoPay\Sorting $sorting Sorting object
+     * @param Pagination $pagination Pagination object
+     * @param Sorting $sorting Sorting object
      * @return \MangoPay\Card[] List of Cards corresponding to provided fingerprint
      */
     public function GetByFingerprint($fingerprint, & $pagination = null, $sorting = null)
@@ -33,8 +33,8 @@ public function GetByFingerprint($fingerprint, & $pagination = null, $sorting =
 
     /**
      * Update card
-     * @param \MangoPay\Card $card Card object to save
-     * @return \MangoPay\Card Card object returned from API
+     * @param Card $card Card object to save
+     * @return Card Card object returned from API
      */
     public function Update($card)
     {
@@ -44,9 +44,9 @@ public function Update($card)
     /**
      * Gets a Card's PreAuthorizations
      * @param int $cardId ID of the Card for which to retrieve PreAuthorizations
-     * @param \MangoPay\Pagination $pagination Pagination object
-     * @param \MangoPay\FilterPreAuthorizations filter Filtering object
-     * @param \MangoPay\Sorting $sorting Sorting object
+     * @param Pagination $pagination Pagination object
+     * @param FilterPreAuthorizations filter Filtering object
+     * @param Sorting $sorting Sorting object
      * @return \MangoPay\CardPreAuthorization[] List of the Card's PreAuthorizations
      */
     public function GetPreAuthorizations($cardId, $pagination = null, $filter = null, $sorting = null)
@@ -57,9 +57,9 @@ public function GetPreAuthorizations($cardId, $pagination = null, $filter = null
     /**
      * Retrieves a list of Transactions pertaining to a certain Card
      * @param string $cardId Card identifier
-     * @param \MangoPay\Pagination $pagination Pagination object
-     * @param \MangoPay\FilterTransactions $filter Filtering object
-     * @param \MangoPay\Sorting $sorting Sorting object
+     * @param Pagination $pagination Pagination object
+     * @param FilterTransactions $filter Filtering object
+     * @param Sorting $sorting Sorting object
      * @return \MangoPay\Transaction[]
      */
     public function GetTransactions($cardId, & $pagination = null, $filter = null, $sorting = null)
@@ -70,7 +70,7 @@ public function GetTransactions($cardId, & $pagination = null, $filter = null, $
     /**
      * Validate a card
      * @param $cardId
-     * @return \MangoPay\CardValidation
+     * @return CardValidation
      * @throws Libraries\Exception
      */
     public function ValidateCard($cardId, $cardValidation)
@@ -81,7 +81,7 @@ public function ValidateCard($cardId, $cardValidation)
     /**
      * Get card validation
      * @param $cardId, $cardValidationId
-     * @return \MangoPay\Card
+     * @return Card
      * @throws Libraries\Exception
      */
     public function GetCardValidation($cardId, $cardValidationId)