Skip to content

[WIP] Automated request of codeowner for PR review #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

europ
Copy link
Member

@europ europ commented Mar 27, 2018

[WIP]

This was necessary due to the fact that there is not possible to choose number zero for required approving reviews in the settings of branch protection. Codeowners are requested for a pull request review depending on specifications defined in CODEOWNERS file. This file includes files specifications and authors related to them. Files from the PR are compared if they match any of the pattern defined in the codeowners file. If there is match then a corresponding user is requested for a review.

This was necessary due to the fact that there is not possible to choose number zero for required approving reviews in the settings of branch protection. Codeowners are requested for a pull request review depending on specifications defined in CODEOWNERS file. This file includes files specifications and authors related to them. Files from the PR are compared if they match any of the pattern defined in the codeowners file. If there is match then a corresponding user is requested for a review.
@miq-bot
Copy link
Member

miq-bot commented Mar 28, 2018

Some comments on commit europ@a1a725e

app/workers/codeowner_review_request.rb

  • 💣 💥 🔥 🚒 - 2 - Detected byebug. Remove all debugging statements.
  • 💣 💥 🔥 🚒 - 20 - Detected binding.pry. Remove all debugging statements.

@miq-bot
Copy link
Member

miq-bot commented Mar 28, 2018

Checked commit europ@a1a725e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 22 offenses detected

app/workers/codeowner_review_request.rb

@europ
Copy link
Member Author

europ commented Apr 3, 2018

@skateman

GitHub has fixed this already. This pull request is useless from now ...

@europ europ closed this Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants