Fix of issues in remove_reviewer command

[europ]

The merge of #411 can cause undesirable problems.

In lib/github_service/commands/remove_reviewer.rb is an method missing error due to a dependent octokit/octokit.rb#990 which is not merged yet and also an undefined two local variables error which is due to wrong method call.

The errors undefined local variable fq_repo_name and undefined local variable number were fixed with correct calling as an issue method call.

The undefined method delete_pull_request_review_request error is solved via catching NoMethodError exception. The call of this method will inform the requester of remove_reviewer command that this command is currently not working and it will perform no action (only posting a github comment with this informative text). This is a temporary solution until merge of octokit/octokit.rb#990.

---

Errors

• undefined local variable fq_repo_name

2018-03-22T16:48:45.326Z 15110 TID-grjjui1pk GithubNotificationMonitorWorker JID-6d1eab0b08206f522c5b5f18 ERROR: undefined local variable or method `fq_repo_name' for #<GithubService::Commands::RemoveReviewer:0x00005607f6e7cd78>
2018-03-22T16:48:45.327Z 15110 TID-grjjui1pk GithubNotificationMonitorWorker JID-6d1eab0b08206f522c5b5f18 ERROR: /root/miq_bot/lib/github_service/commands/remove_reviewer.rb:28:in `requested_reviewers'
/root/miq_bot/lib/github_service/commands/remove_reviewer.rb:13:in `_execute'
/root/miq_bot/lib/github_service/commands/base.rb:33:in `execute!'
/root/miq_bot/lib/github_service/command_dispatcher.rb:36:in `block in dispatch!'
/root/miq_bot/lib/github_service/command_dispatcher.rb:26:in `each'
/root/miq_bot/lib/github_service/command_dispatcher.rb:26:in `dispatch!'
...

• undefined local variable number

2018-03-22T18:34:12.120Z 16901 TID-gnk6maz3k GithubNotificationMonitorWorker JID-350692fa2e343c95c4eb66d3 ERROR: undefined local variable or method `number' for #<GithubService::Commands::RemoveReviewer:0x00005576a6dd7da0>
2018-03-22T18:34:12.121Z 16901 TID-gnk6maz3k GithubNotificationMonitorWorker JID-350692fa2e343c95c4eb66d3 ERROR: /root/miq_bot/lib/github_service/commands/remove_reviewer.rb:22:in `requested_reviewers'
/root/miq_bot/lib/github_service/commands/remove_reviewer.rb:10:in `_execute'
/root/miq_bot/lib/github_service/commands/base.rb:33:in `execute!'
/root/miq_bot/lib/github_service/command_dispatcher.rb:36:in `block in dispatch!'
/root/miq_bot/lib/github_service/command_dispatcher.rb:26:in `each'
/root/miq_bot/lib/github_service/command_dispatcher.rb:26:in `dispatch!'
...

• undefined method delete_pull_request_review_request

2018-03-22T17:26:27.343Z 16084 TID-gscdlbkhc GithubNotificationMonitorWorker JID-0abb1835ec1b698abd2c5769 ERROR: undefined method `delete_pull_request_review_request' for GithubService:Module
2018-03-22T17:26:27.343Z 16084 TID-gscdlbkhc GithubNotificationMonitorWorker JID-0abb1835ec1b698abd2c5769 ERROR: /root/miq_bot/lib/github_service.rb:158:in `method_missing'
/root/miq_bot/lib/github_service/issue.rb:18:in `remove_reviewer'
/root/miq_bot/lib/github_service/commands/remove_reviewer.rb:11:in `_execute'
/root/miq_bot/lib/github_service/commands/base.rb:33:in `execute!'
/root/miq_bot/lib/github_service/command_dispatcher.rb:36:in `block in dispatch!'
/root/miq_bot/lib/github_service/command_dispatcher.rb:26:in `each'
/root/miq_bot/lib/github_service/command_dispatcher.rb:26:in `dispatch!'
...

\cc
@Fryguy
@skateman

[europ]

@miq-bot add_label bug

[europ]

@miq-bot add_reviewer @skateman

[miq-bot]

@europ 'skateman' is an invalid reviewer, ignoring...

[skateman]

Why am I an invalid reviewer?

[miq-bot]

Checked commits europ/miq_bot@212da59~...91123f5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍