Skip to content

Conversation

@skateman
Copy link
Member

@skateman skateman commented Sep 7, 2016

  • Renamed files containing the word dynatree and updated references
  • Renamed MiqDynatree to MiqTree in JS function names
  • Renamed tree_autoload_dynatree routes to tree_autoload
  • Renamed TreeBuilder methods containing the word dynatree

@miq-bot
Copy link
Member

miq-bot commented Sep 7, 2016

<github_pr_commenter_batch />Some comments on commits skateman/manageiq@f858f7d~...dcff85b

app/views/miq_policy/_profile_list.html.haml

  • ⚠️ - 15 - Detected pp. Remove all debugging statements.

app/views/report/_role_list.html.haml

  • ⚠️ - 28 - Detected pp. Remove all debugging statements.

@miq-bot
Copy link
Member

miq-bot commented Sep 7, 2016

Checked commits skateman/manageiq@f858f7d~...dcff85b with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
55 files checked, 8 offenses detected

app/views/layouts/gtl/_list.html.haml

  • ⚠️ - Line 251 - Comment should have a space after the #

app/views/miq_ae_customization/_dialog_edit_tree.html.haml

  • ⚠️ - Line 12 - Prefer to_s over string interpolation.

app/views/ops/_rbac_group_details.html.haml

  • ⚠️ - Line 63 - Avoid more than 3 levels of block nesting.
  • ⚠️ - Line 63 - Redundant curly braces around a hash parameter.
  • ⚠️ - Line 63 - Use params[:onclick] = "miqTreeActivateNode('rbac_tree', 'tn-#{to_cid(tenant.id)}');"; params[:title] = tenant.divisible ? _("View this Tenant") : _("View this Project") instead of params.merge!({:onclick => "miqTreeActivateNode('rbac_tree', 'tn-#{to_cid(tenant.id)}');", :title => tenant.divisible ? _("View this Tenant") : _("View this Project")}).

app/views/ops/_rbac_user_details.html.haml

  • ⚠️ - Line 100 - Line is too long. [166/160]
  • ⚠️ - Line 122 - Line is too long. [180/160]

app/views/report/_report_list.html.haml

  • ⚠️ - Line 90 - Line is too long. [212/160]

@martinpovolny martinpovolny added this to the Sprint 46 Ending Sep 12, 2016 milestone Sep 7, 2016
@martinpovolny martinpovolny merged commit f94a597 into ManageIQ:master Sep 7, 2016
@skateman skateman deleted the dynatree-rename branch September 7, 2016 12:02
martinpovolny added a commit to martinpovolny/manageiq that referenced this pull request Sep 7, 2016
chessbyte added a commit that referenced this pull request Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants