Skip to content

Conversation

@liu-samuel
Copy link

@liu-samuel liu-samuel commented Nov 19, 2024

Fixes: #7397

Before:
Screenshot 2024-11-19 at 12 33 54 AM

After:
Screenshot 2024-11-19 at 12 33 12 AM

@liu-samuel liu-samuel requested a review from a team as a code owner November 19, 2024 05:34
@liu-samuel liu-samuel force-pushed the help-menu-form-conversion branch from d367450 to d93588a Compare November 19, 2024 05:36
@liu-samuel liu-samuel force-pushed the help-menu-form-conversion branch 3 times, most recently from cb7dfdc to 177e712 Compare November 19, 2024 06:06
@miq-bot
Copy link
Member

miq-bot commented Feb 24, 2025

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot
Copy link
Member

miq-bot commented Mar 5, 2025

Checked commits liu-samuel/manageiq-ui-classic@d93588a~...872b1e9 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
4 files checked, 18 offenses detected

app/views/ops/_settings_help_menu_tab.html.haml

  • ⚠️ - Line 10 - Line contains trailing whitespace
  • ⚠️ - Line 11 - Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
  • ⚠️ - Line 11 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
  • ⚠️ - Line 4 - 5 consecutive Ruby scripts can be merged into a single :ruby filter
  • ⚠️ - Line 4 - Avoid using instance variables in partials views
  • ⚠️ - Line 4 - Line is too long. [86/80]
  • ⚠️ - Line 4 - Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity.
  • ⚠️ - Line 5 - 4 consecutive Ruby scripts can be merged into a single :ruby filter
  • ⚠️ - Line 5 - Avoid using instance variables in partials views
  • ⚠️ - Line 5 - Line is too long. [90/80]
  • ⚠️ - Line 5 - Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity.
  • ⚠️ - Line 6 - 3 consecutive Ruby scripts can be merged into a single :ruby filter
  • ⚠️ - Line 6 - Avoid using instance variables in partials views
  • ⚠️ - Line 6 - Line is too long. [87/80]
  • ⚠️ - Line 6 - Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity.
  • ⚠️ - Line 7 - Style/HashSyntax: Use hash rockets syntax.
  • ⚠️ - Line 7 - Style/HashSyntax: Use hash rockets syntax.
  • ⚠️ - Line 7 - Style/HashSyntax: Use hash rockets syntax.

@miq-bot
Copy link
Member

miq-bot commented Mar 5, 2025

Some comments on commits liu-samuel/manageiq-ui-classic@d93588a~...872b1e9

498c9cc

  • ⚠️ - Merge commit 498c9cc detected. Consider rebasing.

@miq-bot
Copy link
Member

miq-bot commented Jun 9, 2025

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@GilbertCherrie
Copy link
Member

Issues with this pr

  • The help form is appearing on other tabs of the settings
  • The old form submit button is still present

Need to fix these before merge.

Copy link
Member

@GilbertCherrie GilbertCherrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix the issues listed above first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Form conversion: Configuration/Settings/Region/Help Menu

3 participants