Skip to content

Conversation

@GilbertCherrie
Copy link
Member

@GilbertCherrie GilbertCherrie commented Nov 10, 2023

Fixes: #6918

In manageiq-providers-amazon / app / models / authenticator / amazon.rb need to update this function self.validate_connection in order to return json for the new React form

@GilbertCherrie GilbertCherrie requested a review from a team as a code owner November 10, 2023 20:27
@GilbertCherrie GilbertCherrie force-pushed the convert_settings_authentication_form branch from ab16785 to 3db4b90 Compare February 21, 2024 13:54
@miq-bot miq-bot added the stale label Jun 3, 2024
@miq-bot
Copy link
Member

miq-bot commented Jun 3, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@GilbertCherrie GilbertCherrie force-pushed the convert_settings_authentication_form branch from 3992568 to fa0b7a8 Compare June 12, 2024 20:24
@miq-bot
Copy link
Member

miq-bot commented Jun 13, 2024

Checked commits GilbertCherrie/manageiq-ui-classic@b5a7dfa~...5456e41 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
3 files checked, 6 offenses detected

app/controllers/ops_controller/settings/common.rb

app/views/ops/_settings_authentication_tab.html.haml

  • ⚠️ - Line 5 - Avoid using instance variables in partials views
  • ⚠️ - Line 5 - Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
  • ⚠️ - Line 5 - Layout/SpaceInsideHashLiteralBraces: Space inside } detected.
  • ⚠️ - Line 5 - Line is too long. [141/80]

@miq-bot
Copy link
Member

miq-bot commented Nov 1, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

2 similar comments
@miq-bot
Copy link
Member

miq-bot commented Feb 3, 2025

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot
Copy link
Member

miq-bot commented May 5, 2025

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@GilbertCherrie GilbertCherrie force-pushed the convert_settings_authentication_form branch from 5456e41 to 5046d7e Compare October 8, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Form conversion: Configuration Settings/Server/Authentication

2 participants