Remove unused angular controllers #8427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GilbertCherrie
force-pushed
the
remove_unused_controllers
branch
from
d7f3342 to
2937812
Compare
Member
Author
GilbertCherrie
changed the title
GilbertCherrie
force-pushed
the
remove_unused_controllers
branch
from
2937812 to
07d7cbb
Compare
GilbertCherrie
force-pushed
the
remove_unused_controllers
branch
from
07d7cbb to
090edaf
Compare
GilbertCherrie
changed the title
GilbertCherrie
changed the title
GilbertCherrie
changed the title
GilbertCherrie
changed the title
GilbertCherrie
changed the title
Member
|
@ManageIQ/core-ui team please review. |
jeffibm
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused angular controllers.
The chart-mixin.js controller has been replaced with the non-angular file chart_config.js so this controller can also be removed.
The controller cloud_volume_form_controller.js can be deleted since the cloud volumes forms have already been converted to react and this controller file was no longer being used anywhere in the code.
The controller fonticon_picker_controller.js can be deleted since this component was already converted to react in pr: #6985 so this controller is no longer being used and no longer needed.