-
Notifications
You must be signed in to change notification settings - Fork 368
Rewrite Set retirement date form to DDF/React #7518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
68d9fd6 to
1ef04c3
Compare
|
@skateman i am seeing couple of differences/issues between new vs old retirement form
|
That's correct, if you look at other forms, I am just making this consistent...
Because it's done asynchronously, you need workers 😉
Updated by making the date field required... |
|
Checked commit skateman@84d19bf with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint **
|
|
@h-kataria updated |
|
@h-kataria can you please retest according to the updates? |








Rewriting the angular component to an API-driven DDF/React form. I made some simplifications to the behavior when setting the date for multiple items, it's not loading the old retirement date for a single item selected undeterministically and it's not setting the retirement its warning message for all affected items. However, when editing a single item, this still happens as it should ...
Fixes #6845
Replaces #7441