Skip to content

Conversation

@skateman
Copy link
Member

Rewriting the angular component to an API-driven DDF/React form. I made some simplifications to the behavior when setting the date for multiple items, it's not loading the old retirement date for a single item selected undeterministically and it's not setting the retirement its warning message for all affected items. However, when editing a single item, this still happens as it should ...

Fixes #6845
Replaces #7441

@skateman skateman requested a review from h-kataria November 19, 2020 11:07
@miq-bot miq-bot added the wip label Nov 19, 2020
@skateman skateman force-pushed the retire-ddf branch 3 times, most recently from 68d9fd6 to 1ef04c3 Compare November 19, 2020 13:59
@skateman skateman changed the title [WIP] Rewrite Set retirement date form to DDF/React Rewrite Set retirement date form to DDF/React Nov 19, 2020
@skateman skateman requested a review from himdel November 19, 2020 14:01
@miq-bot miq-bot removed the wip label Nov 19, 2020
@h-kataria
Copy link
Contributor

h-kataria commented Nov 19, 2020

@skateman i am seeing couple of differences/issues between new vs old retirement form

  1. when cancelling out from retirement form, flash message is a warning message on new form
    before
    Screenshot from 2020-11-19 16-44-28
    after
    Screenshot from 2020-11-19 16-40-11

  2. Retirement date is not getting saved on new form
    before
    Screenshot from 2020-11-19 16-44-55
    after
    Screenshot from 2020-11-19 16-41-01
    Screenshot from 2020-11-19 16-41-35

  3. when I only changed value of Retirement Warning field and press save button, nothing happens on VM retirement screen(no errors and data is not saved either), on Service retirement screen i get a JS error
    before, shows saved values correctly for Retirement Warning
    Screenshot from 2020-11-19 16-45-30
    after, value did not get saved on VM retirement for Retirement Warning field
    Screenshot from 2020-11-19 16-41-54
    Service Retirement, throws an error when trying to save Retirement Warning field
    Screenshot from 2020-11-19 16-39-50

@skateman
Copy link
Member Author

skateman commented Nov 20, 2020

  1. when cancelling out from retirement form, flash message is a warning message on new form

That's correct, if you look at other forms, I am just making this consistent...

  1. Retirement date is not getting saved on new form

Because it's done asynchronously, you need workers 😉

  1. when I only changed value of Retirement Warning field and press save button, nothing happens on VM retirement screen(no errors and data is not saved either), on Service retirement screen i get a JS error

Updated by making the date field required...

@skateman skateman changed the title Rewrite Set retirement date form to DDF/React [WIP] Rewrite Set retirement date form to DDF/React Nov 20, 2020
@miq-bot miq-bot added the wip label Nov 20, 2020
@skateman skateman changed the title [WIP] Rewrite Set retirement date form to DDF/React Rewrite Set retirement date form to DDF/React Nov 20, 2020
@miq-bot miq-bot removed the wip label Nov 20, 2020
@miq-bot
Copy link
Member

miq-bot commented Nov 20, 2020

Checked commit skateman@84d19bf with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
7 files checked, 2 offenses detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby26, which recognizes
warning: 2.6.6-compliant syntax, but you are running 2.6.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

  • 💣 💥 🔥 🚒 - Linter/Rubocop - Linter::Rubocop STDERR:
/tmp/d20201120-7-1wcvgxb/config/routes.rb: Warning: no department given for MultilineOperationIndentation. Run `rubocop -a --only Migration/DepartmentName` to fix.

@skateman
Copy link
Member Author

@h-kataria updated

@skateman
Copy link
Member Author

skateman commented Dec 7, 2020

@h-kataria can you please retest according to the updates?

@skateman skateman closed this Dec 7, 2020
@skateman skateman reopened this Dec 7, 2020
@asirvadAbrahamVarghese asirvadAbrahamVarghese mentioned this pull request Aug 4, 2025
84 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Form conversion: Services Set Retirement

4 participants