Skip to content

Conversation

@skateman
Copy link
Member

@skateman skateman commented Oct 9, 2020

I did some cleanup in the TreeView codebase, we now have the following components:

  • TreeViewBase - a component that renders a tree without using redux
  • TreeViewRedux - a component that renders a tree with redux
  • TreeViewField - a DDF component that uses TreeViewBase and exposes checkboxes
  • TreeViewSelector - a DDF component that uses a TEXT_FIELD with a button addon that opens a Modal containing a tree where you can select a single entity
{
    component: 'tree-selector',
    name: 'foo',
    label: 'Foo',
    loadData: () => http.get('/tree/test'),
    lazyLoadData: node => http.get(`/tree/test?id=${node.attr.key}`),
    identifier: node => node.fqname,
}

Screenshot from 2020-10-10 16-07-43
Screenshot from 2020-10-10 16-07-26
Screenshot from 2020-10-10 16-07-35

Fixes #6841

@skateman skateman requested review from h-kataria and himdel October 9, 2020 15:40
@miq-bot miq-bot added the wip label Oct 9, 2020
@skateman skateman force-pushed the tree-view branch 5 times, most recently from 8728951 to 334679d Compare October 10, 2020 16:23
@skateman skateman changed the title [WIP] Implemented the TreeViewSelector component for DDF Implemented the TreeViewSelector component for DDF Oct 10, 2020
@miq-bot miq-bot removed the wip label Oct 10, 2020
@skateman skateman changed the title Implemented the TreeViewSelector component for DDF [WIP] Implemented the TreeViewSelector component for DDF Oct 12, 2020
@miq-bot miq-bot added the wip label Oct 12, 2020
@skateman skateman changed the title [WIP] Implemented the TreeViewSelector component for DDF Implemented the TreeViewSelector component for DDF Oct 12, 2020
@miq-bot miq-bot removed the wip label Oct 12, 2020
@himdel
Copy link
Contributor

himdel commented Oct 12, 2020

Settings > Application Settings >> Access Control .. edit a role
with this PR, all the checkboxes in the Product Features tree are unchecked

@skateman
Copy link
Member Author

Settings > Application Settings >> Access Control .. edit a role
with this PR, all the checkboxes in the Product Features tree are unchecked

Fixed...

@miq-bot
Copy link
Member

miq-bot commented Oct 13, 2020

Checked commits skateman/manageiq-ui-classic@740c62c~...a7e5c70 with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby26, which recognizes
warning: 2.6.6-compliant syntax, but you are running 2.6.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@himdel himdel self-assigned this Oct 13, 2020
@himdel himdel merged commit 3a2ee81 into ManageIQ:master Oct 13, 2020
@skateman skateman deleted the tree-view branch October 14, 2020 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing react component: tree select

3 participants