Sort the webpack modules for consistent output #7332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Checked commit Fryguy@5581af0 with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
simaishi
pushed a commit
that referenced
this pull request
Sep 24, 2020
Sort the webpack modules for consistent output (cherry picked from commit bee2cdc)
Contributor
|
Jansa backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@himdel Please review. We had sorted it originally, but when we switched to generating the packages only it was irrelevant. So when we added back the modules list it was unsorted.