Replace the physical infra provider forms with the DDF-based new one #7091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Checked commit skateman@9a9dac3 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint app/views/ems_physical_infra/edit.html.haml
app/views/ems_physical_infra/new.html.haml |
h-kataria
approved these changes
May 29, 2020
Contributor
h-kataria
left a comment
h-kataria
left a comment
There was a problem hiding this comment.
Looks good, was able to verify new form in UI. Ready to be merged once dependent PRs are merged.
himdel
approved these changes
Jun 22, 2020
37 tasks
Member
Author
|
Dependencies resolved, this can go in @h-kataria @himdel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are just two physical infra providers with a fairly easy schema to migrate.
Depends on:
ManageIQ/manageiq-providers-redfish#115
ManageIQ/manageiq-providers-lenovo#304
Fixes: #6855
Parent issue: ManageIQ/manageiq#18818