fonticon-picker: show modal when clicking on the icon, not only the chrevon #7001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hevron for consistency with selects, and general ease of use :)
himdel
commented
Apr 27, 2020
| setState(state => ({ ...state, showModal: false, selectedIcon: activeIcon })); | ||
| }; | ||
|
|
||
| const hideModal = () => setState(state => ({ ...state, showModal: false })); |
Contributor
Author
There was a problem hiding this comment.
renamed because we already have a showModal boolean
h-kataria
added
jansa/yes?
services
bug
enhancement
jansa/no
and removed
bug
jansa/yes?
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the fonticon picker component (#6985) to react when clicking on the whole element, instead of only the chevron.
For consistency with selects, and general ease of use :)
The problem:
Now clicking the icon also shows the modal.