TreeBuilder* - remove dead id_prefix #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chessbyte
reviewed
Mar 14, 2017
| def set_locals_for_render | ||
| locals = super | ||
| locals.merge!(:id_prefix => 'nt_', :autoload => true) | ||
| locals.merge!(:autoload => true) |
Member
There was a problem hiding this comment.
maybe the simpler code below is better:
locals = super
locals[:autoload] = true
locals # if caller is expecting the hash to be returned
Contributor
Author
There was a problem hiding this comment.
fixed :)
I'll probably do a separate PR to unify all the various ways this function is written to something that just returns a hash..
Member
|
@himdel as far as i remember we had a BZ for a tree where this |
Member
Used to be used before ManageIQ/manageiq#10767, dead since then.
Member
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/167be8982bb303ebfb716fc81993b89674ba4bf9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Contributor
Author
|
@skateman hard to believe since this never gets used in JS :) any chance you can find the BZ? (and yeah, it can wait since you're on PTO :)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
id_prefixin treebuilders used to be used before ManageIQ/manageiq#10767, but has been dead since then, removing.(Removed in https://github.com/ManageIQ/manageiq/pull/10767/files#diff-68c04f575f602a2ea2b246518f9b0acdL6 and https://github.com/ManageIQ/manageiq/pull/10767/files#diff-e4bb0ff2bbc5a334b211e9b8684210e0L231)
Cc @skateman