Migrate service dialog from orchestration template from to data driven forms #5627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Hyperkid123
force-pushed
the
service-dialog-from-ot-form
branch
from
a5e389e to
fcdf1ed
Compare
8 tasks
Hyperkid123
force-pushed
the
service-dialog-from-ot-form
branch
from
fcdf1ed to
400d0d1
Compare
Contributor
Author
|
Ignore the extra commits will remove all of it once dependencies are merged |
Hyperkid123
force-pushed
the
service-dialog-from-ot-form
branch
3 times, most recently
from
6d8c616 to
10d4729
Compare
Hyperkid123
force-pushed
the
service-dialog-from-ot-form
branch
2 times, most recently
from
b32163b to
35e3308
Compare
Hyperkid123
changed the title
Contributor
|
@Hyperkid123 Are you sure about the description in the initial comment? |
Contributor
Author
Thanks (different PR) |
Hyperkid123
force-pushed
the
service-dialog-from-ot-form
branch
from
35e3308 to
0820785
Compare
Contributor
Author
Hyperkid123
force-pushed
the
service-dialog-from-ot-form
branch
4 times, most recently
from
f95be12 to
bfa92fd
Compare
rvsia
approved these changes
Jun 27, 2019
Contributor
rvsia
left a comment
rvsia
left a comment
There was a problem hiding this comment.
Tested in UI, works great! 👍
Hyperkid123
force-pushed
the
service-dialog-from-ot-form
branch
from
bfa92fd to
f0f829e
Compare
mzazrivec
reviewed
Jun 28, 2019
| <MiqFormRenderer | ||
| schema={serviceDialogFromOtSchema} | ||
| onSubmit={onSubmit} | ||
| onCancel={() => miqRedirectBack('Creation of a new Service Dialog was cancelled by the user', 'success', '/catalog/explorer')} |
Contributor
There was a problem hiding this comment.
Missing gettext perhaps?
Hyperkid123
force-pushed
the
service-dialog-from-ot-form
branch
from
f0f829e to
38c3b1c
Compare
Member
|
Checked commit Hyperkid123@38c3b1c with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Form is at
Service > Catalogs > Orchestration Templates tab > select template > open Configuration dropdown > Create service Dialog from orchestration templateBefore
After
waiting for:
ManageIQ/manageiq-api#596and#5552