Skip to content

Flavor add form converted to data-driven-forms #5055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
martinpovolny merged 2 commits into from
Jan 8, 2019
Merged

Flavor add form converted to data-driven-forms #5055

martinpovolny merged 2 commits into from
Jan 8, 2019

Conversation

@rvsia
Copy link
Contributor

@rvsia rvsia commented Dec 6, 2018 •
edited
Loading

Description

  • Converts Compute > Clouds > Flavors > Configuration > Add a new Flavor to Data-driven form
  • Updates Data-driven forms dependencies

Before

screenshot from 2018-12-20 09-53-57

After

image

@miq-bot miq-bot added the wip label Dec 6, 2018
@rvsia rvsia force-pushed the flavor_form_to_react branch from 7458052 to ee4fd38 Compare December 6, 2018 15:59
@miq-bot
Copy link
Member

miq-bot commented Dec 7, 2018

This pull request is not mergeable. Please rebase and repush.

@rvsia rvsia force-pushed the flavor_form_to_react branch 2 times, most recently from f59bf07 to f72b823 Compare December 12, 2018 15:20
@rvsia rvsia force-pushed the flavor_form_to_react branch 4 times, most recently from d57f143 to 44995e4 Compare December 19, 2018 11:21
@rvsia
Copy link
Contributor Author

rvsia commented Dec 20, 2018

@miq-bot add_label hammer/no, compute/cloud, react, refactoring

@rvsia rvsia force-pushed the flavor_form_to_react branch 6 times, most recently from 11e5c4d to 04009cb Compare December 20, 2018 13:22
@rvsia rvsia force-pushed the flavor_form_to_react branch 2 times, most recently from 4fc903e to 5027c52 Compare December 20, 2018 13:27
@rvsia
Copy link
Contributor Author

rvsia commented Dec 20, 2018

@miq-bot add_reviewer @Hyperkid123

@rvsia rvsia changed the title [WIP] Flavor add form converted to data-driven-forms Flavor add form converted to data-driven-forms Dec 20, 2018
@miq-bot miq-bot removed the wip label Dec 20, 2018
@miq-bot miq-bot requested a review from Hyperkid123 December 20, 2018 13:32
@rvsia rvsia force-pushed the flavor_form_to_react branch from 5027c52 to b08e214 Compare January 2, 2019 08:28
@martinpovolny
Copy link
Member

martinpovolny commented Jan 7, 2019

Out of the new lines ~400 are specs. So while this looks longer than the original. It's actually not.

@martinpovolny
Copy link
Member

martinpovolny commented Jan 7, 2019

@ZitaNemeckova : can we, please, have your thoroughness on testing this in the UI?

@ZitaNemeckova
Copy link
Contributor

ZitaNemeckova commented Jan 7, 2019 •
edited
Loading

Only difference I found is that instead of letting user write whatever and showing an error message it now doesn't show any written letters. But I don't see any problem with that :)

LGTM 👍

Edit: Tested in UI. I don't feel I know enough to review code.

@miq-bot
Copy link
Member

miq-bot commented Jan 7, 2019

Checked commits rvsia/manageiq-ui-classic@9765e35~...b08e214 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@martinpovolny martinpovolny added this to the Sprint 103 Ending Jan 21, 2019 milestone Jan 8, 2019
@martinpovolny martinpovolny merged commit 25e0abe into ManageIQ:master Jan 8, 2019
@rvsia rvsia mentioned this pull request Apr 12, 2019
Merged
@rvsia rvsia deleted the flavor_form_to_react branch September 17, 2019 12:01
@himdel himdel mentioned this pull request Apr 3, 2020
Closed
@asirvadAbrahamVarghese asirvadAbrahamVarghese mentioned this pull request Aug 4, 2025
Open
84 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hyperkid123 Hyperkid123 Awaiting requested review from Hyperkid123

Assignees

@ZitaNemeckova ZitaNemeckova

Labels

compute/cloud hammer/no react refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rvsia @miq-bot @martinpovolny @ZitaNemeckova