Form conversion: My Settings Visual

[himdel]

Convert form to use DDF/React and API - parent issue #6825

Location: My Settings
Form: Visual

current type: Ruby
API state:
Need info

PM Input: 1 - Low

imported status: NOT ASSIGNED

Missing components:

• subform boxes

[skateman]

Seems like the API has everything we need, under /api/users/<id> there's a settings attribute that contains everything and we are able to edit it as well. I don't think the subform-boxes are really necessary (see the issue linked above) and the only thing we need to deal with is these nice icons as DDF doesn't support them:

I would just replace them with dropdowns with text or if we really want to keep the icons, we could use switch components and maybe include the icons in the onText and offText attribute (not sure if possible). But I think having dropdowns with text increases a11y and it's easy to do. @kavyanekkalapu wdyt?

[skateman]

Do we need the Chart Theme setting? It has a single default value and if I remember it correctly, it was introduced by @PanSpagetka when we replaced the old flash-based charts.

[PanSpagetka]

It was ages ago, I can't remember that I introduced such a thing. I think it might be leftover from flash charts and probably it is not really used. You could try to delete it and with a bit of luck nothing brakes.

[skateman]

@abellotti @gtanzillo I would like to serve the list available timezones, languages and start pages via the API, but I'm not sure how (except maybe the start pages which are stored in the DB) and if it is a good idea and if not, where else should they live. Maybe locales are available in the frontend somehow (cc @himdel @mzazrivec) and I guess we can use moment.tz.names() somehow...

[himdel]

app/helpers/view_helper.rb
13:  ALL_TIMEZONES = ActiveSupport::TimeZone.all.collect { |tz| ["(GMT#{tz.formatted_offset}) #{tz.name}", tz.name] }.freeze

So, the how is simple, create a rest json endpoint to serve that, or pass them to the form.

There's probably nothing on the frontend that can help you, there's (probably?) no guarantee moment-timezone names are 1:1 with ruby timezones. (EDIT: unless both sides can talk Olson timezone Area/Location database names, such as Etc/UTC or Europe/Prague)

[mzazrivec]

@skateman For locale names, maybe something like

diff --git a/app/assets/javascripts/i18n.js b/app/assets/javascripts/i18n.js
index 8ea383d63..65b8aebf7 100644
--- a/app/assets/javascripts/i18n.js
+++ b/app/assets/javascripts/i18n.js
@@ -10,4 +10,10 @@ $(function() {
       return '\u00BB' + i18n.ngettext.apply(i18n, arguments) + '\u00AB';
     };
   }
+
+  window.human_available_locales = {};
+
+  Object.keys(locales).forEach(lang => {
+    human_available_locales[lang] = locales[lang].locale_data.app.locale_name[0]
+  });
 });

Or maybe there's a nicer way to do this, not sure. Maybe @himdel knows :-)

[himdel]

Or maybe there's a nicer way to do this, not sure.

Yes, ask the backend :). Extracting list of timezones from the translation catalog doesn't sound ..stable :).

EDIT: it also gives the wrong list - this is locales, not timezones.

EDIT2: I'm OK with Milan's way of extracting locale names, but there's no way to use the same approach for timezones, so why not get everything from the API