Collect AWS service catalog items #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gtanzillo @gmcculloug @syncrou not sure if we should require the admin access? Or what permissions you would envision we would have. Also it looks like I can only see provisioned instances of what my account provisioned, I haven't found any admin view of all provisioned instances. |
Ladas
force-pushed
the
collect_service_catalog_items
branch
from
b0b27ba to
8c4cd99
Compare
agrare
reviewed
Sep 4, 2018
| @@ -68,6 +68,10 @@ def aws_cloud_formation | |||
| @aws_cloud_formation ||= manager.connect(:service => :CloudFormation) | |||
| end | |||
|
|
|||
| def aws_service_catalog | |||
| @aws_service_catalog = manager.connect(:service => :ServiceCatalog) | |||
There was a problem hiding this comment.
Should be @aws_service_catalog ||=
agrare
reviewed
Sep 4, 2018
| @@ -342,4 +344,64 @@ def key_pairs | |||
| ) | |||
| end | |||
| end | |||
|
|
|||
| def service_offerings | |||
| collector.service_offerings.each do |service_offering| | |||
There was a problem hiding this comment.
What is the order of magnitude of the number of service offerings? Hundreds/thousands/etc...
Doing API calls in a loop over a collection sucks :/
There was a problem hiding this comment.
not sure, but there'll be few of those. Only way to make it work nicely is multi-thread + targeted refresh (if possible)
Ladas
force-pushed
the
collect_service_catalog_items
branch
from
8c4cd99 to
156183b
Compare
Link of service instance and offering. The record also contains a link to stack, which we do not have modeled yet.
Passign specs after VCR refresh
Hide warnings about service catalog unavailable, since service catalog is not officially supported.
Ladas
force-pushed
the
collect_service_catalog_items
branch
from
c8ad34c to
adf8dd7
Compare
Ladas
force-pushed
the
collect_service_catalog_items
branch
from
4386a53 to
48f6d31
Compare
Ladas
force-pushed
the
collect_service_catalog_items
branch
from
7cb47e8 to
5bafdb4
Compare
|
Some comments on commits Ladas/manageiq-providers-amazon@0f5223a~...5bafdb4 spec/models/manageiq/providers/amazon/aws_refresher_spec_common.rb
spec/vcr_cassettes/manageiq/providers/amazon/cloud_manager/refresher.yml
spec/vcr_cassettes/manageiq/providers/amazon/cloud_manager/refresher_inventory_object.yml
|
|
Checked commits Ladas/manageiq-providers-amazon@0f5223a~...5bafdb4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 app/models/manageiq/providers/amazon/inventory/collector/cloud_manager.rb
spec/models/manageiq/providers/amazon/aws_refresher_spec_counts.rb
|
agrare
approved these changes
Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect AWS service catalog items.
For refresh it needs role:
ServiceCatalogAdminReadOnlyAccess
TODO:
Depends on: