allow raw_connect to validate the connection and decrypt the password #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit jntullo@83f4090 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot assign @blomquisg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI is moving towards validating credentials on the queue to allow for validating credentials in separate zones utilizing the
raw_connectclass method, rather than needing to create a temporary EMS for validation.For many of the providers,
raw_connectensures the credentials are correct. This updatesraw_connectto not only return a connection but also be able to validate (it will not validate by default).Because credentials are going to be stored on the queue, it also needs to be able to decrypt them. This uses
MiqPassword.try_decryptso that it can accept both unencrypted and encrypted credentials.PR with greater detail: ManageIQ/manageiq-ui-classic#1580