Collect encryption status of cloud volume snapshot #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @gberginc |
sasoc
force-pushed
the
collect_encrypted_status_for_snapshot
branch
from
527788b to
fa3587a
Compare
gberginc
reviewed
Jun 12, 2017
| @@ -82,6 +82,7 @@ def refresh_spec_full | |||
|
|
|||
| assert_specific_snapshot | |||
| assert_specific_volume | |||
| assert_unencrypted_snapshot | |||
There was a problem hiding this comment.
Change the order - move assert_unencrypted_snapsthot before assert_specific_volume.
|
@miq-bot add_label pending core |
sasoc
force-pushed
the
collect_encrypted_status_for_snapshot
branch
from
fa3587a to
8515e62
Compare
UI has encrypted attribute included, but it is rendered empty for the user.
sasoc
force-pushed
the
collect_encrypted_status_for_snapshot
branch
from
8515e62 to
db86dc1
Compare
|
Checked commit sasoc@db86dc1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Thanks @sasoc. To me this looks better to have tests properly grouped. |
|
@Ladas can you review this one? |
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Jun 20, 2017
ManageIQ could have new columns added so we want to migrate/reset our sample manageiq app's test db when running bin/setup or bin/update. For a mostly unrelated PR [1] that was open for a while, another PR [2] with a dependent migration on manageiq were both merged causing my development branch for [1] to fail because I had already setup the initial test database and bin/setup and bin/update were not migrating the test database to include the newly added column. [1] ManageIQ/manageiq-providers-amazon#256 [2] ManageIQ/manageiq-providers-amazon#259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI has encrypted attribute included, but it is rendered empty for the user.
Depends on: ManageIQ/manageiq#15352