Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Amazon S3 StorageManager #106

Merged
merged 2 commits into from
Jan 18, 2017
Merged

Introduce Amazon S3 StorageManager #106

merged 2 commits into from
Jan 18, 2017

Conversation

aiperon
Copy link
Contributor

@aiperon aiperon commented Jan 17, 2017

Similarly to #101 this commit sets up the core structure of the new AWS S3 manager.
It provides just the basic stubs and tests that are to be extended.

The refresher collects data about existing buckets.

@miq-bot add_label enhancement

This was referenced Jan 17, 2017
Closed
Closed
@Ladas
Copy link
Contributor

Ladas commented Jan 17, 2017 •
edited
Loading

@aiperon ok, I think first we will merge #101

this one will probably conflict then. Could you fix the rubocop warnings with Style... in the meantime?

otherwise, looks like a good 1st step

@Ladas Ladas self-assigned this Jan 17, 2017
@miq-bot
Copy link
Member

miq-bot commented Jan 17, 2017

This pull request is not mergeable. Please rebase and repush.

@Ladas
Copy link
Contributor

Ladas commented Jan 17, 2017

@aiperon could you rebase and follow what was done in? #101

You don't need to push the new version of a refresher and a parser in this PR though, it can come later. So just cleanup according to #101 and this is ready.

@Ladas Ladas added the euwe/no label Jan 17, 2017
@aiperon aiperon force-pushed the introduce_s3_manager branch 3 times, most recently from 418997b to 704eaf0 Compare January 17, 2017 14:38
@aiperon aiperon closed this Jan 17, 2017
@aiperon aiperon reopened this Jan 17, 2017
@aiperon aiperon force-pushed the introduce_s3_manager branch from 704eaf0 to 8964210 Compare January 17, 2017 14:47
@aiperon
Copy link
Contributor Author

aiperon commented Jan 17, 2017

I've rebased my branch, fixed style issues and followed recommendations for #101.

@aiperon aiperon changed the title Introduce Amazon ObjectStorageManager (S3) [WIP] Introduce Amazon ObjectStorageManager (S3) Jan 17, 2017
@aiperon aiperon force-pushed the introduce_s3_manager branch from 8964210 to 4e9c1e1 Compare January 18, 2017 09:57
@aiperon aiperon changed the title [WIP] Introduce Amazon ObjectStorageManager (S3) Introduce Amazon S3 StorageManager Jan 18, 2017
@aiperon aiperon force-pushed the introduce_s3_manager branch from 4e9c1e1 to 2ee3d7b Compare January 18, 2017 10:09
@aiperon aiperon mentioned this pull request Jan 18, 2017
Closed
@miq-bot
Copy link
Member

miq-bot commented Jan 18, 2017

@aiperon Cannot apply the following label because they are not recognized: wip

@aiperon aiperon force-pushed the introduce_s3_manager branch 2 times, most recently from 1332c3a to 98a03fa Compare January 18, 2017 16:03
@aiperon
Copy link
Contributor Author

aiperon commented Jan 18, 2017 •
edited
Loading

Added new version of a refresher and a parser.
Renamed from
ManageIQ::Providers::Amazon::ObjectStorageManager < ManageIQ::Providers::StorageManager
to
ManageIQ::Providers::Amazon::StorageManager::EBS < ManageIQ::Providers::StorageManager.

@Ladas @gberginc @roliveri please review

@aiperon aiperon force-pushed the introduce_s3_manager branch 3 times, most recently from 27eacd5 to 8f478cb Compare January 18, 2017 16:34
@Ladas
Copy link
Contributor

Ladas commented Jan 18, 2017

@aiperon ah, I think rename caused you need to rebase again :-)

@miq-bot
Copy link
Member

miq-bot commented Jan 18, 2017

This pull request is not mergeable. Please rebase and repush.

@aiperon
Introduce Amazon ObjectStorageManager (S3)
e57e466 
Basic stubs and test for management of Amazon S3
@aiperon
S3 parser for Inventory Objects using Inventory abstraction
f500c6e 
Similarly to ManageIQ#102.
Adds support for inventory collection using inventory abstraction.
It mimics existing cloud, network and ebs managers.
@aiperon aiperon force-pushed the introduce_s3_manager branch from 8f478cb to f500c6e Compare January 18, 2017 17:42
@miq-bot
Copy link
Member

miq-bot commented Jan 18, 2017

Checked commits aiperon/manageiq-providers-amazon@e57e466~...f500c6e with ruby 2.2.6, rubocop 0.46.0, and haml-lint 0.19.0
18 files checked, 6 offenses detected

app/models/manageiq/providers/amazon/storage_manager/s3/refresh_parser_inventory_object.rb

app/models/manageiq/providers/amazon/storage_manager/s3/refresher.rb

spec/models/manageiq/providers/amazon/storage_manager/s3/stubbed_refresher_spec.rb

@aiperon
Copy link
Contributor Author

aiperon commented Jan 18, 2017

@Ladas fortunately it's not a big deal in that case. Done & green.

@Ladas
Copy link
Contributor

Ladas commented Jan 18, 2017

@aiperon looks great, thank you for the contribution :-)

@Ladas Ladas merged commit ed13b17 into ManageIQ:master Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ladas Ladas

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aiperon @Ladas @miq-bot